CFE-4626, CFE-4624: Fixes ordering on dep-table and better error on too few arguments #13
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: CFE-4626 Changelog: None Signed-off-by: Simon Halvorsen <simon.halvorsen@northern.tech>
Ticket: CFE-4624 Changelog: None Signed-off-by: Simon Halvorsen <simon.halvorsen@northern.tech>
|
Thank you for submitting a pull request! Maybe @larsewi can review this? |
larsewi
approved these changes
Jan 13, 2026
larsewi
reviewed
Jan 13, 2026
src/cfengine_cli/main.py
Outdated
| pdt.add_argument( | ||
| "versions", | ||
| nargs="+", | ||
| help="Versions to compare\n\t (minimum 1 required)", |
Contributor
There was a problem hiding this comment.
Looks like the \n\t is ignored, or does it mean something special in this context?
$ python3 cfengine_cli dev print-dependency-tables --help
usage: cfengine_cli dev print-dependency-tables [-h] versions [versions ...]
positional arguments:
versions Versions to compare (minimum 1 required)
options:
-h, --help show this help message and exit
Maybe just remove them if not?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.