-
Notifications
You must be signed in to change notification settings - Fork 98
Addressing (some) stainless notion doc comments #264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 9 files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 issues found across 2 files (changes from recent commits).
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="README.md">
<violation number="1" location="README.md:232">
P1: User-facing installation command requires uv, which most users won't have installed. This should use standard pip for general usage instructions.</violation>
</file>
<file name="CONTRIBUTING.md">
<violation number="1" location="CONTRIBUTING.md:94">
P2: Use `uv pip install` instead of `uv run pip install`. The correct uv syntax for pip operations is `uv pip <command>`, not `uv run pip <command>`.</violation>
<violation number="2" location="CONTRIBUTING.md:112">
P2: Use `uv pip install` instead of `uv run pip install`. The correct uv syntax for pip operations is `uv pip <command>`, not `uv run pip <command>`.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
# why Once [this PR](browserbase/stagehand-python#264) is merged into core, we no longer need to send `x-language` and `x-sdk-version` headers in our generated SDKs, since they send the `x-stainless` equivalents automatically. # what changed Thus, this PR removes these from the openapi spec, so that the generated clients will stop having these fields. # test plan Will ensure that new generated sdks work successfully. <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Removed x-language and x-sdk-version headers from the OpenAPI spec and server types, since generated SDKs now send x-stainless headers automatically. This simplifies SDK generation and removes redundant headers. - **Migration** - Regenerate SDKs after the core change that adds x-stainless headers is merged. - Stop sending x-language and x-sdk-version in clients; rely on x-stainless headers. <sup>Written for commit df65fe9. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. -->
why
Addressing some of the notion comments for stainless python.
what changed
uvtest plan
Summary by cubic
Adds sessions.create() that returns a Session/AsyncSession bound to a session_id, so you can call session methods without passing id on every request. Moves examples and docs to AsyncStagehand and fixes session_id state issues.
New Features
Migration
Written for commit ba50c85. Summary will update on new commits.