Fix implementation of --dangerously-auto-approve-everything flag #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The --dangerously-auto-approve-everything flag was defined in CLI but not implemented in the approval policy logic. This caused the sandboxing error "The combination of seccomp/landlock that Codex uses for sandboxing is not supported in this environment" to persist even when using the flag. Changes: - Added "dangerous-auto" to ApprovalPolicy type - Added DANGEROUS_AUTO to AutoApprovalMode enum - Updated CLI approval policy logic to handle the flag with highest priority - Updated canAutoApprove() function to auto-approve all commands without sandboxing - Updated canAutoApproveApplyPatch() to handle dangerous-auto mode - Added comprehensive tests for the new approval mode This resolves the issue where users in Docker containers or environments without seccomp/landlock support could not bypass sandboxing requirements using the intended --dangerously-auto-approve-everything flag. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a bug where the
--dangerously-auto-approve-everythingflag was defined in the CLI but not properly implemented in the approval policy logic. This caused users in Docker containers or environments without seccomp/landlock support to still encounter the sandboxing error even when using the intended bypass flag.Problem
The error message "The combination of seccomp/landlock that Codex uses for sandboxing is not supported in this environment" would appear even when using
--dangerously-auto-approve-everything, because:fullAutoandautoEdit, not the dangerous flagcanAutoApprove()function had no handling for the "dangerous-auto" modeSolution
"dangerous-auto"to theApprovalPolicytype definitionDANGEROUS_AUTOto theAutoApprovalModeenum--dangerously-auto-approve-everythingflagcanAutoApprove()function to auto-approve all commands without sandboxing in dangerous-auto modecanAutoApproveApplyPatch()to handle dangerous-auto mode properlyTesting
Added
tests/dangerous-auto-approve.test.tswith 4 test cases:Test plan
🤖 Generated with Claude Code