fix: exclude absolute file paths from slash command detection #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent absolute file paths (e.g., /Desktop/file, /home/user/project) from being incorrectly detected as slash commands by checking if the first word after '/' contains another '/'. - Updated isSlashCommand() to filter out absolute file paths - Added comprehensive test cases for file path detection - Ensures valid slash commands like /help, /memory still work correctly
| // Exclude absolute file paths (e.g., /Desktop/file, /home/user/project) | ||
| // Check if there's a second '/' in the first word (before any space) | ||
| // This catches patterns like /Desktop/, /home/, /usr/, etc. | ||
| const afterSlash = query.substring(1); |
There was a problem hiding this comment.
Consider adding the @ symbold if its a path to comply with the standard path designation.
| // Check if there's a second '/' in the first word (before any space) | ||
| // This catches patterns like /Desktop/, /home/, /usr/, etc. | ||
| const afterSlash = query.substring(1); | ||
| const firstWord = afterSlash.split(/\s/)[0]; |
There was a problem hiding this comment.
Can we cover "" paths for windows as well?
Add comment suggesting users should use @/path/to/file instead of /path/to/file to comply with the standard file path designation.
Add support for detecting and excluding Windows paths (e.g., C:\Users\..., \path\to\file) from being treated as slash commands. - Updated isSlashCommand() to check for backslashes in addition to forward slashes - Added test cases for Windows-style paths - Updated documentation to mention Windows path support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent absolute file paths (e.g., /Desktop/file, /home/user/project) from being incorrectly detected as slash commands by checking if the first word after '/' contains another '/'.