station-m3: Fix fan speed and enable USB 3.0 Type-A port #9177
Conversation
kasimling
requested review from
ColorfulRhino,
HeyMeco,
JohnTheCoolingFan,
SuperKali,
TheSnowfield,
Tonymac32,
ahoneybun,
amazingfate,
brentr,
catalinii,
chainsx,
efectn,
igorpecovnik,
joekhoobyar,
krachlatte,
lanefu,
paolosabatino,
prahal,
pyavitz,
rpardini and
schwar3kat
as code owners
📝 WalkthroughWalkthroughTwo patches for Rockchip RK3588 device tree (kernel 6.18 and 6.19) add automatic temperature-based fan control through a new thermal node, introduce a second PCIe port configuration (pcie2x1l2), and enable USB 3.0 Type-A host controller support for the rk3588s-roc-pc board. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (2)
🧰 Additional context used🧠 Learnings (7)📓 Common learnings📚 Learning: 2025-12-08T04:43:44.601ZApplied to files:
📚 Learning: 2026-01-03T07:27:40.951ZApplied to files:
📚 Learning: 2025-12-17T05:09:02.306ZApplied to files:
📚 Learning: 2025-12-19T13:56:45.124ZApplied to files:
📚 Learning: 2026-01-03T07:27:45.955ZApplied to files:
📚 Learning: 2025-11-20T18:20:11.985ZApplied to files:
🔇 Additional comments (7)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
bot
added
02
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In
@patch/kernel/archive/rockchip64-6.19/rk3588-1212-arm64-dts-rk3588s-roc-pc-Add-Thermal-fix-pcie.patch:
- Around line 36-40: The cooling-map entry map1 is using THERMAL_NO_LIMIT as the
min_state (cooling-device = <&fan THERMAL_NO_LIMIT 1>), which is wrong; change
that to a valid min state (e.g., 1) so the line becomes cooling-device = <&fan 1
N>; where N is the intended max_state for that fan level (use 1 if you want a
fixed low speed at 55°C or a higher number if a range is intended), and ensure
THERMAL_NO_LIMIT is only used as a max_state where appropriate in other maps.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
patch/kernel/archive/rockchip64-6.19/rk3588-1212-arm64-dts-rk3588s-roc-pc-Add-Thermal-fix-pcie.patchpatch/kernel/archive/rockchip64-6.19/rk3588-1213-arm64-dts-rk3588s-roc-pc-Enable-usbhost2-xhci.patch
🧰 Additional context used
🧠 Learnings (4)
📓 Common learnings
Learnt from: Lemon1151
Repo: armbian/build PR: 0
File: :0-0
Timestamp: 2025-12-08T04:43:44.601Z
Learning: On the rk3399-fine3399 board, the PWM fan requires cooling-levels to extend to 255 (full duty cycle) in the device tree. With cooling-levels ending at 160, the fan fails to spin up even when temperature exceeds the thermal threshold. This is a hardware characteristic specific to this board's fan configuration.
Learnt from: iav
Repo: armbian/build PR: 9158
File: patch/kernel/archive/rockchip64-6.18/add-board-helios64.patch:598-600
Timestamp: 2026-01-03T07:27:45.955Z
Learning: In Rockchip vendor kernel branches (e.g., rockchip64-6.18), the FUSB302 device tree binding accepts usb-role-switch as a phandle reference to a USB role switch provider (e.g., typec_extcon_bridge), not just as a boolean flag as in mainline kernel bindings. The vendor implementation allows usb-role-switch = <&typec_extcon_bridge>; to work correctly.
Learnt from: HackingGate
Repo: armbian/build PR: 8665
File: config/boards/photonicat2.csc:4-4
Timestamp: 2025-10-26T10:41:35.118Z
Learning: In the Armbian build system, rk3576 boards consistently use BOARDFAMILY="rk35xx" for both vendor and edge kernel targets. The rk35xx family configuration sources rockchip64_common.inc, which provides edge and current kernel branch definitions, making these branches available even though they're not defined directly in rk35xx.conf.
Learnt from: rpardini
Repo: armbian/build PR: 8879
File: config/sources/families/uefi-x86.conf:0-0
Timestamp: 2025-11-06T15:36:04.682Z
Learning: As of PR #8879, the uefi-x86 family in the Armbian build system now includes kernel patches for the first time. The current and edge branches for uefi-x86 are specifically configured for Apple T2-based x86 machines, including T2-specific patches from the linux-t2 project and custom kernel configuration options for Apple hardware drivers.
Learnt from: igorpecovnik
Repo: armbian/build PR: 8789
File: config/kernel/linux-sunxi64-edge.config:839-839
Timestamp: 2025-10-22T07:51:53.015Z
Learning: In Armbian's wireless driver configuration, CONFIG_RK_WIFI_DEVICE_* options are Rockchip-specific device registration settings, while CONFIG_WLAN_UWE* are the actual cross-platform driver modules for UWE5622 wireless chips. The UWE5622 chip (manufactured by Unisoc/Spreadtrum) is used on multiple Allwinner boards including Orange Pi Zero 2/2W/3 and Orange Pi 3 LTS, so CONFIG_WLAN_UWE5621/5622 along with Unisoc infrastructure options (CONFIG_SPARD_WLAN_SUPPORT, CONFIG_SC23XX, CONFIG_UNISOC_WIFI_PS, CONFIG_WCN_BSP_DRIVER_BUILDIN) are correct in sunxi64 kernel configs.
📚 Learning: 2026-01-03T07:27:45.955Z
Learnt from: iav
Repo: armbian/build PR: 9158
File: patch/kernel/archive/rockchip64-6.18/add-board-helios64.patch:598-600
Timestamp: 2026-01-03T07:27:45.955Z
Learning: In Rockchip vendor kernel branches (e.g., rockchip64-6.18), the FUSB302 device tree binding accepts usb-role-switch as a phandle reference to a USB role switch provider (e.g., typec_extcon_bridge), not just as a boolean flag as in mainline kernel bindings. The vendor implementation allows usb-role-switch = <&typec_extcon_bridge>; to work correctly.
Applied to files:
patch/kernel/archive/rockchip64-6.19/rk3588-1213-arm64-dts-rk3588s-roc-pc-Enable-usbhost2-xhci.patch
📚 Learning: 2025-12-08T04:43:44.601Z
Learnt from: Lemon1151
Repo: armbian/build PR: 0
File: :0-0
Timestamp: 2025-12-08T04:43:44.601Z
Learning: On the rk3399-fine3399 board, the PWM fan requires cooling-levels to extend to 255 (full duty cycle) in the device tree. With cooling-levels ending at 160, the fan fails to spin up even when temperature exceeds the thermal threshold. This is a hardware characteristic specific to this board's fan configuration.
Applied to files:
patch/kernel/archive/rockchip64-6.19/rk3588-1212-arm64-dts-rk3588s-roc-pc-Add-Thermal-fix-pcie.patch
📚 Learning: 2025-12-17T05:09:02.306Z
Learnt from: EvilOlaf
Repo: armbian/build PR: 0
File: :0-0
Timestamp: 2025-12-17T05:09:02.306Z
Learning: In the Armbian build system, kernel patches (e.g., in patch/kernel/archive/sunxi-6.18/patches.armbian/) contain device tree overlays and other code that have existed for years and are maintained/ported across kernel versions. When reviewing PRs that modify these patch files, focus on the actual changes being made (e.g., Makefile fixes, new additions) rather than reviewing the entire existing content within the patch as if it were new code. The patch file contents are existing, stable code unless explicitly modified in the PR diff.
Applied to files:
patch/kernel/archive/rockchip64-6.19/rk3588-1212-arm64-dts-rk3588s-roc-pc-Add-Thermal-fix-pcie.patch
🔇 Additional comments (3)
patch/kernel/archive/rockchip64-6.19/rk3588-1213-arm64-dts-rk3588s-roc-pc-Enable-usbhost2-xhci.patch (1)
9-12: LGTM! USB host controller properly configured.The configuration correctly enables the USB host2 xHCI controller in host-only mode, which is appropriate for the USB 3.0 Type-A port.
patch/kernel/archive/rockchip64-6.19/rk3588-1212-arm64-dts-rk3588s-roc-pc-Add-Thermal-fix-pcie.patch (2)
48-51: The PCIe controller change from pcie2x1l1 to pcie2x1l2 appears to be an intentional hardware fix.The patch header explicitly states "fix pcie2x", and this change is consistent with other similar RK3588s boards (rk3588s-youyeetoo-r1, rk3588s-orangepi-5-pro, rk3588s-nanopi-m6) in the same kernel version, which also configure GPIO3_PD1 (the reset GPIO) with pcie2x1l2 rather than pcie2x1l1. The hardware wiring for this board design appears to route the reset pin to pcie2x1l2 only, making this a deliberate correction rather than a problematic change.
20-46: Verify that the fan node includes adequate cooling-levels array entries.The thermal zone configuration references
&fanas a cooling device with levels 1 and 2 in the cooling-maps. Ensure the fan node definition in the base device tree includes acooling-levelsproperty with sufficient entries to support these indexed levels (minimum 3 entries for indices 0, 1, and 2). Similar board implementations use arrays like<0 120 150 180 210 240 255>or<100 160 190 200 215 235 255>. Some boards may require cooling-levels extending to 255 for full PWM duty cycle operation.
...chive/rockchip64-6.18/rk3588-1212-arm64-dts-Automatic-fan-speed-and-USB-3.0-Type-A-por.patch
Show resolved
Hide resolved
|
Consider if you want to maintain three different patches on the same DT. |
|
It is possible to consider merging the two patches into one. |
|
There's also a third which sent previously. |
|
Also, this one is only for 6.19/edge -- 6.18 has the 1st patch. Suggestion, unify all 3 then PR both 6.18 and 6.19 together. |
@rpardini , are you referring to the package_thermal fix? I see there are such fixes for some RK3588 devices on 6.18 but not for station-m3. Right, I'll create one unify PR for both 6.18 and 6.19 kernel. |
Signed-off-by: Alex Ling <ling_kasim@hotmail.com>
kasimling
force-pushed
the
rockchip_dev
branch
from
946d830 to
bb503ff
Compare
3 participants
Description
This PR includes following changes
1.Adjust fan speed to CPU core temperature
2.Enable USB 3.0 support on the Type-A port
How Has This Been Tested?
1.Check the fan speed should be low when booting into desktop
2.Run command "stress-ng -v --cpu 8" to burn CPU and check if the fan speed is increased
3.Check if the USB 3.0 device is connected correctly via "lsusb"
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.