Skip to content

Conversation

@ItzNotABug
Copy link
Member

@ItzNotABug ItzNotABug commented Jan 17, 2026

What does this PR do?

Adds changelog entry and resource updates related to execution log retention based on plans.

Test Plan

Manual.

Related PRs and Issues

N/A.

Have you read the Contributing Guidelines on issues?

Yes.

Summary by CodeRabbit

  • Documentation
    • Added changelog entry documenting execution logs retention limits by plan.
  • New Features
    • Updated pricing comparison to show execution logs retained: Free (100), Pro (1,000), Scale (Unlimited), Enterprise (Custom).
  • Bug Fixes / Improvements
    • Improved resilience of pricing/plan UI rendering and behavior in non-browser environments.

✏️ Tip: You can customize this high-level summary in your review settings.

@ItzNotABug ItzNotABug self-assigned this Jan 17, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 17, 2026

Walkthrough

This pull request updates the format script to run Prettier with caching, adds browser-environment guards in utilities to avoid localStorage access and defaults platform detection to ClientWeb when not in a browser, changes a Svelte each-block key to include the item index, adds a changelog entry describing per-plan execution log retention, and inserts an "Execution logs" row into the pricing comparison table with per-plan limits.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title 'Add: changelog and plan changes' is vague and generic, using non-descriptive terms that don't clearly convey the specific changeset. While it mentions changelog and plan changes, it lacks specificity about the actual feature being added (execution log retention limits). Make the title more specific by including the key feature: 'Add execution log retention limits to pricing plans' or similar, which clearly describes what is being added.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Fix all issues with AI agents
In `@src/routes/changelog/`(entries)/2026-01-19.markdoc:
- Around line 11-12: The changelog wording ("100 execution logs per
function/site" / "1,000 execution logs per function/site") conflicts with the
pricing table's "/ month" phrasing; update the changelog entry in
2026-01-19.markdoc to explicitly state these are rolling retention limits (e.g.,
"maximum retained at any time (rolling retention): 100 execution logs per
function/site" and "1,000 execution logs per function/site") so it matches the
intent shown in compare-plans.svelte, or alternatively remove "/ month" from the
pricing table—pick one approach and make the wording consistent across
2026-01-19.markdoc and compare-plans.svelte.

In `@src/routes/pricing/compare-plans.svelte`:
- Around line 75-82: The plan entry titled "Execution logs" currently appends "/
month" to the free/pro values which conflicts with the info tooltip describing
rolling retention; update the object for the "Execution logs" entry by removing
the "/ month" suffix from the free and pro strings (and adjust scale/enterprise
if needed) so values reflect retained counts (e.g., "100", "1000", "Unlimited",
"Custom") and ensure the info text remains "Number of execution logs retained
per function/site".
🧹 Nitpick comments (1)
src/routes/(marketing)/(components)/pricing.svelte (1)

102-102: Consider simplifying the composite key.

Since name is already unique across all plans (Free, Pro, Scale, Enterprise), the composite key ${name},${label},${index} is redundant. Including index in the key can also reduce Svelte's ability to optimize DOM reuse when the list order changes.

Unless there's a specific reactivity issue this addresses, simplifying to just name would be cleaner:

-{`#each` visiblePlans as { name, price, tag: label, subtitle, description, event }, index (`${name},${label},${index}`)}
+{`#each` visiblePlans as { name, price, tag: label, subtitle, description, event } (name)}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants