Skip to content

Implement ExternalService Framework #17009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Wei-hao-Li wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Implement ExternalService Framework #17009

Wei-hao-Li wants to merge 8 commits into from
+3,655 −2

Conversation

@Wei-hao-Li
Copy link
Collaborator

@Wei-hao-Li Wei-hao-Li commented Jan 12, 2026

No description provided.

@Wei-hao-Li
add api
4d61221 
Signed-off-by: Weihao Li <18110526956@163.com>
@Wei-hao-Li
Merge branch 'master' of github.com:apache/iotdb into exteranlservice
86e3dfa
@Wei-hao-Li
add process in CN: ExternalServiceInfo
8f93984 
Signed-off-by: Weihao Li <18110526956@163.com>
@Wei-hao-Li
draft
720c7c5 
Signed-off-by: Weihao Li <18110526956@163.com>
@Wei-hao-Li
done
3e4cf34 
Signed-off-by: Weihao Li <18110526956@163.com>
@Wei-hao-Li
Merge branch 'master' of github.com:apache/iotdb into exteranlservice
88568d0
@Wei-hao-Li
fix Some
cd49eee 
Signed-off-by: Weihao Li <18110526956@163.com>
@Wei-hao-Li
add snapshot test
3ff5dd2 
Signed-off-by: Weihao Li <18110526956@163.com>
JackieTien97
JackieTien97 requested changes Jan 12, 2026
View reviewed changes
Copy link
Contributor

@JackieTien97 JackieTien97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

partial review, finish CN and antlr parts.

JackieTien97
JackieTien97 requested changes Jan 12, 2026
View reviewed changes
Copy link
Contributor

@JackieTien97 JackieTien97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add all ITs you list in the documents and the recovery process is missing

...rg/apache/iotdb/db/queryengine/plan/execution/config/executor/ClusterConfigTaskExecutor.java
ExternalServiceManagementService.getInstance().stopService(serviceName);
future.set(new ConfigTaskResult(new TSStatus(TSStatusCode.SUCCESS_STATUS.getStatusCode())));
} catch (Exception e) {
future.setException(new ExternalServiceManagementException(e.getMessage()));
Copy link
Contributor

@JackieTien97 JackieTien97 Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

...rg/apache/iotdb/db/queryengine/plan/execution/config/executor/ClusterConfigTaskExecutor.java
ExternalServiceManagementService.getInstance().dropService(serviceName, forcedly);
future.set(new ConfigTaskResult(new TSStatus(TSStatusCode.SUCCESS_STATUS.getStatusCode())));
} catch (Exception e) {
future.setException(new ExternalServiceManagementException(e.getMessage()));
Copy link
Contributor

@JackieTien97 JackieTien97 Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

...rg/apache/iotdb/db/queryengine/plan/execution/config/executor/ClusterConfigTaskExecutor.java
new ConfigTaskResult(
TSStatusCode.SUCCESS_STATUS, builder.build(), getShowExternalServiceHeader()));
} catch (Exception e) {
future.setException(e);
Copy link
Contributor

@JackieTien97 JackieTien97 Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

...tanode/src/main/java/org/apache/iotdb/db/service/exernalservice/BuiltinExternalServices.java
Comment on lines +28 to +35
MQTT(
"MQTT",
"org.apache.iotdb.externalservice.Mqtt",
IoTDBDescriptor.getInstance().getConfig()::isEnableMQTTService),
REST(
"REST",
"org.apache.iotdb.externalservice.Rest",
IoTDBRestServiceDescriptor.getInstance().getConfig()::isEnableRestService);
Copy link
Contributor

@JackieTien97 JackieTien97 Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
MQTT(
"MQTT",
"org.apache.iotdb.externalservice.Mqtt",
IoTDBDescriptor.getInstance().getConfig()::isEnableMQTTService),
REST(
"REST",
"org.apache.iotdb.externalservice.Rest",
IoTDBRestServiceDescriptor.getInstance().getConfig()::isEnableRestService);
MQTT(
"MQTT",
"org.apache.iotdb.externalservice.Mqtt",
// IoTDBDescriptor.getInstance().getConfig()::isEnableMQTTService),
() -> false),
REST(
"REST",
"org.apache.iotdb.externalservice.Rest",
// IoTDBRestServiceDescriptor.getInstance().getConfig()::isEnableRestService);
() -> false);

better always return false before you really seperate the rest and mqtt service outside. Otherwise, mqtt and rest ITs will fail because org.apache.iotdb.externalservice.Mqtt and org.apache.iotdb.externalservice.Rest is not found

...tanode/src/main/java/org/apache/iotdb/db/service/exernalservice/BuiltinExternalServices.java
Comment on lines +28 to +35
MQTT(
"MQTT",
"org.apache.iotdb.externalservice.Mqtt",
IoTDBDescriptor.getInstance().getConfig()::isEnableMQTTService),
REST(
"REST",
"org.apache.iotdb.externalservice.Rest",
IoTDBRestServiceDescriptor.getInstance().getConfig()::isEnableRestService);
Copy link
Contributor

@JackieTien97 JackieTien97 Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
MQTT(
"MQTT",
"org.apache.iotdb.externalservice.Mqtt",
IoTDBDescriptor.getInstance().getConfig()::isEnableMQTTService),
REST(
"REST",
"org.apache.iotdb.externalservice.Rest",
IoTDBRestServiceDescriptor.getInstance().getConfig()::isEnableRestService);
MQTT(
"MQTT",
"org.apache.iotdb.externalservice.Mqtt",
// IoTDBDescriptor.getInstance().getConfig()::isEnableMQTTService),
() -> false),
REST(
"REST",
"org.apache.iotdb.externalservice.Rest",
// IoTDBRestServiceDescriptor.getInstance().getConfig()::isEnableRestService);
() -> false);

better always return false before you really seperate the rest and mqtt service outside. Otherwise, mqtt and rest ITs will fail because org.apache.iotdb.externalservice.Mqtt and org.apache.iotdb.externalservice.Rest is not found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JackieTien97 JackieTien97 JackieTien97 requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Wei-hao-Li @JackieTien97