-
Notifications
You must be signed in to change notification settings - Fork 4
Support Client TLS #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
CritasWang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds TLS/SSL support to the Apache IoTDB C# client, allowing secure connections between clients and IoTDB servers using X.509 certificates.
Changes:
- Added SSL configuration options (
SetUseSslandSetCertificatePath) to both SessionPool and TableSessionPool builders - Updated SessionPool constructors and connection logic to support SSL/TLS transport using
TTlsSocketTransport - Cleaned up unused imports (System.Net.Sockets, System.Numerics, Microsoft.Extensions.Configuration)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| src/Apache.IoTDB/SessionPool.Builder.cs | Added SSL configuration fields and builder methods; updated constructor calls to pass SSL parameters |
| src/Apache.IoTDB/TableSessionPool.Builder.cs | Added SSL configuration fields and builder methods; updated SessionPool instantiation with SSL parameters |
| src/Apache.IoTDB/SessionPool.cs | Added SSL fields, updated constructors, and modified CreateAndOpen to conditionally use TLS transport based on SSL configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.