HBASE-29787 Run Yetus General Checks as a GitHub Action #7566

ndimiduk · 2025-12-19T11:17:46Z

No description provided.

ndimiduk · 2025-12-19T18:11:11Z

I think this is working. Please help me out by double-checking that the checks run by the new system have parity with the jenkins build.

Apache9 · 2025-12-20T09:06:57Z

I think this is working. Please help me out by double-checking that the checks run by the new system have parity with the jenkins build.

Let's just try it on a special branch? Scripts are always hard to review...

Apache9 · 2025-12-20T09:08:52Z

Ah, I saw the checks, let me check the result...

Apache9 · 2025-12-20T09:11:19Z

Seems we missed lots of checks...

+1 overall
Vote	Subsystem	Runtime	Log	Comment
Prechecks
+1	dupname	0m 0s		No case conflicting files found.
+1	@author	0m 0s		The patch does not contain any @author tags.
master Compile Tests
+1	spotless	0m 53s		branch has no errors when running spotless:check.
Patch Compile Tests
+1	codespell	0m 13s		No new issues.
+1	detsecrets	4m 22s		No new issues.
+1	blanks	0m 0s		The patch has no blanks issues.
+1	yamllint	0m 0s		No new issues.
+1	spotless	0m 35s		patch has no errors when running spotless:check.
Other Tests
+1	asflicense	0m 11s		The patch does not generate ASF License warnings.
6m 27s		
Subsystem	Report/Notes
GITHUB PR	https://github.com/apache/hbase/pull/7566
Optional Tests	dupname asflicense codespell detsecrets yamllint spotless
uname	Linux 5359e6d56b16 6.11.0-1018-azure #18~24.04.1-Ubuntu SMP Sat Jun 28 04:46:03 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/github/workspace/src/dev-support/hbase-personality.sh
git revision	master / efb501962294022f359c4cba545386ca4c78c7e9
modules	C: . U: .
versions	git=2.34.1 maven=3.9.9 codespell=2.4.1 detsecrets=1.5.0 yamllint=1.35.1
Powered by	Apache Yetus 0.16.0-SNAPSHOT https://yetus.apache.org
This message was automatically generated.

.github/workflows/yetus-general-check.yml

ndimiduk · 2026-01-12T16:13:14Z

Would appreciate your review on this as well, @gmcdonald .

Apache-HBase · 2026-01-12T19:22:13Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 29s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 14s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 10s		master passed
+1 💚	compile	2m 17s		master passed
+1 💚	javadoc	2m 13s		master passed
+1 💚	shadedjars	5m 54s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 9s		the patch passed
+1 💚	compile	2m 18s		the patch passed
+1 💚	javac	2m 18s		the patch passed
+1 💚	javadoc	2m 6s		the patch passed
-1 ❌	shadedjars	0m 10s		patch has 10 errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 ❌	unit	260m 1s	/patch-unit-root.txt	root in the patch failed.
		288m 15s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7566/25/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#7566
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux df6dd7070405 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `0d236cd`
Default Java	Eclipse Adoptium-17.0.11+9
shadedjars	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7566/25/artifact/yetus-jdk17-hadoop3-check/output/patch-shadedjars.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7566/25/testReport/
Max. process+thread count	4260 (vs. ulimit of 30000)
modules	C: hbase-annotations . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7566/25/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

petersomogyi · 2026-01-13T14:31:43Z

@ndimiduk Very nice improvement!

The link for spotless error redirects to root of the build on the nightly. https://nightlies.apache.org/hbase/HBase-PreCommit-GH-Actions-PR/PR-7566/44//
I was able to find the log by going to the report.html > patch-spotless.txt.

Do you think this can be improved? To be honest, spotless fixes are straightforward so we don't usually need to look at the output, but having a working link would be very useful for new contributors.

ndimiduk · 2026-01-13T14:57:49Z

@petersomogyi I see the spotless link for GHA run 44, it points to https://nightlies.apache.org/hbase/HBase-PreCommit-GH-Actions-PR/PR-7566/44/yetus-general-check/output/patch-spotless.txt . That link works for me and the content appears to match what was presented by jenkins on https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7566/25/artifact/yetus-general-check/output/patch-spotless.txt

petersomogyi · 2026-01-13T15:05:14Z

@petersomogyi I see the spotless link for GHA run 44, it points to https://nightlies.apache.org/hbase/HBase-PreCommit-GH-Actions-PR/PR-7566/44/yetus-general-check/output/patch-spotless.txt . That link works for me and the content appears to match what was presented by jenkins on https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7566/25/artifact/yetus-general-check/output/patch-spotless.txt

Thanks, got it now!
I originally ment the overview at the bottom:

ndimiduk · 2026-01-13T15:06:53Z

Oh, got it. let me see if i can fix that from here.

we need to override these after the githubactions robot sets them so that they point to our nightlies upload path.

github-actions · 2026-01-13T15:34:53Z

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://nightlies.apache.org/hbase/HBase-PreCommit-GH-Actions-PR/PR-7566/45// in case of problems.

Apache-HBase · 2026-01-13T15:38:04Z

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7566/26/console in case of problems.

Apache-HBase · 2026-01-13T15:38:23Z

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7566/26/console in case of problems.

github-actions · 2026-01-13T16:37:57Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 20s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+0 🆗	yamllint	0m 0s		yamllint was not available.
-1 ❌	@author	0m 0s	/results-author.txt	The patch appears to contain 1 @author tags which the community has agreed to not allow in code contributions.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 14s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 17s		master passed
+1 💚	compile	9m 3s		master passed
+1 💚	checkstyle	1m 58s		master passed
+1 💚	spotbugs	8m 23s		master passed
+1 💚	spotless	0m 44s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 2s		the patch passed
+1 💚	compile	8m 57s		the patch passed
+1 💚	javac	8m 57s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 54s		the patch passed
-0 ⚠️	shellcheck	0m 1s	/results-shellcheck.txt	The patch generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1)
+1 💚	spotbugs	8m 44s		the patch passed
+1 💚	hadoopcheck	9m 23s		Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
-1 ❌	spotless	0m 7s	/patch-spotless.txt	patch has 34 errors when running spotless:check, run spotless:apply to fix.
			_ Other Tests _
-1 ❌	asflicense	0m 19s	/results-asflicense.txt	The patch generated 1 ASF License warnings.
		63m 8s

Subsystem	Report/Notes
Docker	ClientAPI=1.48 ServerAPI=1.48 base: https://nightlies.apache.org/hbase/HBase-PreCommit-GH-Actions-PR/PR-7566/45/yetus-general-check/output/Dockerfile
GITHUB PR	#7566
Optional Tests	dupname asflicense codespell detsecrets shellcheck shelldocs spotless yamllint javac spotbugs checkstyle compile hadoopcheck hbaseanti
uname	Linux ac8e6618ae8c 6.11.0-1018-azure #18~24.04.1-Ubuntu SMP Sat Jun 28 04:46:03 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `944dc4b`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	161 (vs. ulimit of 30000)
modules	C: hbase-annotations . U: .
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3 shellcheck=0.8.0
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2026-01-13T16:42:51Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 28s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+0 🆗	yamllint	0m 0s		yamllint was not available.
-1 ❌	@author	0m 0s	/results-author.txt	The patch appears to contain 1 @author tags which the community has agreed to not allow in code contributions.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 20s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 10s		master passed
+1 💚	compile	8m 32s		master passed
+1 💚	checkstyle	2m 22s		master passed
+1 💚	spotbugs	7m 40s		master passed
+1 💚	spotless	0m 46s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 7s		the patch passed
+1 💚	compile	8m 30s		the patch passed
+1 💚	javac	8m 30s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	2m 15s		the patch passed
-0 ⚠️	shellcheck	0m 1s	/results-shellcheck.txt	The patch generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1)
+1 💚	spotbugs	7m 44s		the patch passed
+1 💚	hadoopcheck	12m 7s		Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
-1 ❌	spotless	0m 8s	/patch-spotless.txt	patch has 34 errors when running spotless:check, run spotless:apply to fix.
			_ Other Tests _
-1 ❌	asflicense	0m 19s	/results-asflicense.txt	The patch generated 1 ASF License warnings.
		65m 34s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7566/26/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#7566
Optional Tests	dupname asflicense codespell detsecrets shellcheck shelldocs spotless yamllint javac spotbugs checkstyle compile hadoopcheck hbaseanti
uname	Linux 197fe26dbd82 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `944dc4b`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	190 (vs. ulimit of 30000)
modules	C: hbase-annotations . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7566/26/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3 shellcheck=0.8.0
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2026-01-13T19:47:56Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 22s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 11s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 32s		master passed
+1 💚	compile	1m 35s		master passed
+1 💚	javadoc	1m 32s		master passed
+1 💚	shadedjars	4m 15s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 10s		the patch passed
+1 💚	compile	1m 36s		the patch passed
+1 💚	javac	1m 36s		the patch passed
+1 💚	javadoc	1m 31s		the patch passed
-1 ❌	shadedjars	0m 6s		patch has 10 errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 ❌	unit	228m 34s	/patch-unit-root.txt	root in the patch failed.
		250m 11s

Subsystem	Report/Notes
Docker	ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7566/26/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#7566
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux c2b6ff7f2deb 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `944dc4b`
Default Java	Eclipse Adoptium-17.0.11+9
shadedjars	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7566/26/artifact/yetus-jdk17-hadoop3-check/output/patch-shadedjars.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7566/26/testReport/
Max. process+thread count	6511 (vs. ulimit of 30000)
modules	C: hbase-annotations . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7566/26/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

This comment has been minimized.

Sign in to view

ndimiduk changed the title ~~HBASE-29787 Move static checks to a Github Action~~ HBASE-29787 Run static checks to a Github Action Dec 19, 2025

This comment has been minimized.

Sign in to view

ndimiduk marked this pull request as ready for review December 19, 2025 18:09

ndimiduk requested review from Apache9, NihalJain, charlesconnell, petersomogyi and stoty December 19, 2025 18:10

Apache9 reviewed Dec 20, 2025

View reviewed changes

.github/workflows/yetus-general-check.yml Outdated Show resolved Hide resolved

ndimiduk requested a review from gmcdonald January 12, 2026 16:13

ndimiduk added 16 commits January 13, 2026 16:30

HBASE-29787 Run Yetus General Checks as a GitHub Action

de577b7

remote path probably still needs hbase prefix

c3a2801

explicitly create remote path on nightlies before rsync

8cbe4ad

try something else to fix build artifact urls

0381634

rsync with -no-o to preserve the more permissive ownership

bdcde1a

enable verbose debugging

e5727e8

conditionally define this robot function yetus bug?

bff21ed

set BUILD_URL and BUILD_URL_ARTIFACTS from personality_globals

79597ec

we need to override these after the githubactions robot sets them so that they point to our nightlies upload path.

make BUILD_URL_ARTIFACTS conditionally required

82f27c8

fix --no-o on rsync

0a7eb5b

remove the extra slash

20961b0

remove debugging of nightlies

0fb27d8

try fix hide old comments

1f7de8e

maybe fix spotless check api link

5af46aa

increase parallelism for first_part surefire tests

c6fcd27

introduce some breakages

944dc4b

ndimiduk force-pushed the 29787-gh-actions-static branch from 0d236cd to 944dc4b Compare January 13, 2026 15:31

HBASE-29787 Run Yetus General Checks as a GitHub Action #7566

Are you sure you want to change the base?

HBASE-29787 Run Yetus General Checks as a GitHub Action #7566

Conversation

ndimiduk commented Dec 19, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ndimiduk commented Dec 19, 2025

Uh oh!

Apache9 commented Dec 20, 2025

Uh oh!

Apache9 commented Dec 20, 2025

Uh oh!

Apache9 commented Dec 20, 2025

Uh oh!

Uh oh!

ndimiduk commented Jan 12, 2026

Uh oh!

Apache-HBase commented Jan 12, 2026

Uh oh!

petersomogyi commented Jan 13, 2026

Uh oh!

ndimiduk commented Jan 13, 2026

Uh oh!

petersomogyi commented Jan 13, 2026

Uh oh!

ndimiduk commented Jan 13, 2026

Uh oh!

github-actions bot commented Jan 13, 2026

Uh oh!

Apache-HBase commented Jan 13, 2026

Uh oh!

Apache-HBase commented Jan 13, 2026

Uh oh!

github-actions bot commented Jan 13, 2026

Uh oh!

Apache-HBase commented Jan 13, 2026

Uh oh!

Apache-HBase commented Jan 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants