Fix mvn warnings #10909

vishesh92 · 2025-05-22T20:48:59Z

Description

This PR fixes the below warnings which appear while building cloudstack.

[WARNING] The following plugins are not marked as thread-safe in Apache CloudStack Client UI:                                                                                                 
[WARNING]   ru.concerteza.buildnumber:maven-jgit-buildnumber-plugin:1.2.6                                                                                                                     
[WARNING]                                                                                                                                                                                     
[WARNING] Enable debug to see precisely which goals are not marked as thread-safe. 

----

[WARNING] The following plugins are not marked @threadSafe in Apache CloudStack Developer Mode:
[WARNING] org.codehaus.mojo:properties-maven-plugin:1.0-alpha-2
[WARNING] Enable debug to see more precisely which goals are not marked @threadSafe.

----

[WARNING] While downloading mysql:mysql-connector-java:8.0.33
  This artifact has been relocated to com.mysql:mysql-connector-j:8.0.33.
  MySQL Connector/J artifacts moved to reverse-DNS compliant Maven 2+ coordinates.

---

[INFO] --- exec:3.2.0:exec (package) @ cloud-marvin ---                                                                                                                                       
[WARNING] [stderr] /home/vishesh/lab/cloudstack/tools/marvin/mvn-setup.py:36: SyntaxWarning: invalid escape sequence '\s'                                                                     
[WARNING] [stderr]   needle = '\nVERSION\s*=\s*[\'"][^\'"]*[\'"]'                                                                                                                             
[WARNING] [stderr] Warning: 'platforms' should be a list, got type 'tuple'                                                                                                                    
[INFO] [stdout] running sdist                                                                                                                                                                 
[INFO] [stdout] running egg_info                                                                                                                                                              
[INFO] [stdout] writing Marvin.egg-info/PKG-INFO                                                                                                                                              
[INFO] [stdout] writing dependency_links to Marvin.egg-info/dependency_links.txt                                                                                                              
[INFO] [stdout] writing entry points to Marvin.egg-info/entry_points.txt                                                                                                                      
[INFO] [stdout] writing requirements to Marvin.egg-info/requires.txt
[INFO] [stdout] writing top-level names to Marvin.egg-info/top_level.txt
[INFO] [stdout] reading manifest template 'MANIFEST.in'
[WARNING] [stderr] warning: no files found matching '*.txt' under directory 'docs'
[INFO] [stdout] adding license file 'LICENSE.txt'
[INFO] [stdout] writing manifest file 'Marvin.egg-info/SOURCES.txt'
[INFO] [stdout] running check
[WARNING] [stderr] warning: sdist: standard file not found: should have one of README, README.rst, README.txt, README.md
[WARNING] [stderr] 
[INFO] [stdout] creating marvin-

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

vishesh92 · 2025-05-22T20:49:25Z

@blueorangutan package

blueorangutan · 2025-05-22T20:50:03Z

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Copilot

Pull Request Overview

This PR resolves various build-time warnings by updating plugin versions, correcting Python setup scripts, and aligning Maven coordinates for MySQL Connector/J. Key changes include:

Adjusted Python packaging scripts (setup.py, mvn-setup.py) to fix type and regex warnings.
Added a minimal README.md for the Marvin client.
Updated Maven plugin versions (properties-maven-plugin, buildnumber-maven-plugin) and migrated MySQL Connector to com.mysql:mysql-connector-j.

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
tools/marvin/setup.py	Switched `platforms` from tuple to list to satisfy setuptools.
tools/marvin/mvn-setup.py	Made regex literal raw string to avoid invalid escape warning.
tools/marvin/README.md	Added basic project README.
tools/devcloud4/pom.xml	Bumped properties-maven-plugin to version 1.2.0.
tools/devcloud-kvm/pom.xml	Bumped properties-maven-plugin to version 1.2.0.
pom.xml	Rebased MySQL connector to `com.mysql:mysql-connector-j` and removed duplicate.
plugins/network-elements/tungsten/pom.xml	Updated MySQL connector coordinates for test scope.
plugins/network-elements/globodns/pom.xml	Updated MySQL connector coordinates for test scope.
framework/db/pom.xml	Updated MySQL connector coordinates.
engine/storage/snapshot/pom.xml	Updated MySQL connector coordinates.
developer/pom.xml	Bumped properties-maven-plugin to version 1.2.0.
client/pom.xml	Switched to `buildnumber-maven-plugin`, updated goals and manifest entries.

Comments suppressed due to low confidence (2)

client/pom.xml:681

After switching to buildnumber-maven-plugin and using its create goal, verify that ${buildNumber} and ${scmBranch} are actually populated. The plugin may require explicit <propertyName> or <branchName> configuration to match these manifest entries.

<goal>create</goal>

tools/marvin/README.md:1

[nitpick] Consider expanding this README with basic installation or quick-start instructions (e.g., dependencies, setup commands) to help new users onboard more quickly.

# Marvin

codecov · 2025-05-22T20:57:20Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.76%. Comparing base (2358632) to head (22b48c3).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #10909      +/-   ##
============================================
- Coverage     17.76%   17.76%   -0.01%     
+ Complexity    15863    15860       -3     
============================================
  Files          5923     5923              
  Lines        530556   530556              
  Branches      64830    64830              
============================================
- Hits          94263    94241      -22     
- Misses       425747   425770      +23     
+ Partials      10546    10545       -1

Flag	Coverage Δ
uitests	`3.57% <ø> (ø)`
unittests	`18.84% <ø> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

blueorangutan · 2025-05-22T21:59:13Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13486

vishesh92 · 2025-05-23T04:17:54Z

@blueorangutan test

blueorangutan · 2025-05-23T04:20:03Z

@vishesh92 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

tools/marvin/README.md

blueorangutan · 2025-05-23T22:17:05Z

[SF] Trillian test result (tid-13376)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 61684 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10909-t13376-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_create_pvlan_network	`Error`	0.17	test_pvlan.py

DaanHoogland

clgtm, but the tests should all pass. Is this applicable to older branches as well?

vishesh92 · 2025-05-26T07:45:21Z

clgtm, but the tests should all pass. Is this applicable to older branches as well?

I doubt the test failure is due to my changes. I think this will be applicable to older branches as well, but I haven't verified.

weizhouapache · 2025-05-26T07:48:57Z

clgtm, but the tests should all pass. Is this applicable to older branches as well?

@DaanHoogland @vishesh92
I think it would be better to keep the target as main/4.21

DaanHoogland · 2026-01-12T09:01:33Z

@blueorangutan package

blueorangutan · 2026-01-12T09:02:05Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-01-12T10:12:59Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16333

weizhouapache

code lgtm

DaanHoogland · 2026-01-12T10:26:21Z

this should have no run-time impact, but running regression tests to be sure anyway.

DaanHoogland · 2026-01-12T10:26:46Z

@blueorangutan test

blueorangutan · 2026-01-12T10:28:04Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

…ven-plugin

DaanHoogland

clgtm

DaanHoogland · 2026-01-12T10:38:53Z

tools/marvin/README.md

@@ -0,0 +1,11 @@
+# Marvin


Suggested change

# Marvin



# Marvin

boring-cyborg bot added component:build component:database component:marvin component:networking component:storage Python Warning... Python code Ahead! labels May 22, 2025

vishesh92 requested a review from Copilot May 22, 2025 20:49

Copilot AI reviewed May 22, 2025

View reviewed changes

bernardodemarco reviewed May 23, 2025

View reviewed changes

tools/marvin/README.md Outdated Show resolved Hide resolved

vishesh92 commented May 23, 2025

View reviewed changes

tools/marvin/README.md Outdated Show resolved Hide resolved

vishesh92 added this to the 4.21.0 milestone May 23, 2025

vishesh92 requested a review from DaanHoogland May 25, 2025 10:23

DaanHoogland reviewed May 25, 2025

View reviewed changes

sureshanaparti added this to Apache CloudStack 4.21.0 Jun 5, 2025

sureshanaparti moved this to In Progress in Apache CloudStack 4.21.0 Jun 5, 2025

weizhouapache modified the milestones: 4.21.0, 4.22.0 Aug 29, 2025

sureshanaparti added this to Apache CloudStack 4.22.0 Aug 29, 2025

sureshanaparti removed this from Apache CloudStack 4.21.0 Aug 29, 2025

sureshanaparti moved this to In Progress in Apache CloudStack 4.22.0 Aug 29, 2025

harikrishna-patnala removed this from the 4.22.0 milestone Nov 12, 2025

harikrishna-patnala added this to the 4.22.1 milestone Nov 12, 2025

harikrishna-patnala removed this from Apache CloudStack 4.22.0 Nov 12, 2025

rajujith added this to Apache CloudStack 4.22.1 Jan 5, 2026

sureshanaparti moved this to In Progress in Apache CloudStack 4.22.1 Jan 7, 2026

vishesh92 changed the base branch from main to 4.20 January 12, 2026 08:25

boring-cyborg bot added component:agent component:api component:integration labels Jan 12, 2026

vishesh92 changed the base branch from 4.20 to main January 12, 2026 08:25

DaanHoogland modified the milestones: 4.22.1, 4.23.0 Jan 12, 2026

DaanHoogland removed this from Apache CloudStack 4.22.1 Jan 12, 2026

weizhouapache approved these changes Jan 12, 2026

View reviewed changes

vishesh92 added 5 commits January 12, 2026 11:30

Replace maven-jgit-buildnumber-plugin with thread safe buildnumber-ma…

4868f0a

…ven-plugin

Fix mysql-connector-java warning

5a9ef56

Fix thread safe warning for properties-maven-plugin

57e0fe6

Fix mvn build - marvin warnings

9432849

Update tools/marvin/README.md

22b48c3

DaanHoogland force-pushed the fix-mvn-warnings branch from 9952d12 to 22b48c3 Compare January 12, 2026 10:30

DaanHoogland approved these changes Jan 12, 2026

View reviewed changes

DaanHoogland reviewed Jan 12, 2026

View reviewed changes

-# Marvin
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements.  See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership.  The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License.  You may obtain a copy of the License at
+   http://www.apache.org/licenses/LICENSE-2.0
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied.  See the License for the
+ specific language governing permissions and limitations
+ under the License.
+ -->
+# Marvin

Fix mvn warnings #10909

Are you sure you want to change the base?

Fix mvn warnings #10909

Uh oh!

Conversation

vishesh92 commented May 22, 2025

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

vishesh92 commented May 22, 2025

Uh oh!

blueorangutan commented May 22, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

codecov bot commented May 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented May 22, 2025

Uh oh!

vishesh92 commented May 23, 2025

Uh oh!

blueorangutan commented May 23, 2025

Uh oh!

Uh oh!

Uh oh!

blueorangutan commented May 23, 2025

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

vishesh92 commented May 26, 2025

Uh oh!

weizhouapache commented May 26, 2025

Uh oh!

DaanHoogland commented Jan 12, 2026

Uh oh!

blueorangutan commented Jan 12, 2026

Uh oh!

blueorangutan commented Jan 12, 2026

Uh oh!

weizhouapache left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Jan 12, 2026

Uh oh!

DaanHoogland commented Jan 12, 2026

Uh oh!

blueorangutan commented Jan 12, 2026

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov bot commented May 22, 2025 •

edited

Loading