Handle multiple architectures: filter out architectures that dont match with machine's architecture #459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add 4 integration tests for XcodeList.update() that verify architecture filtering - Tests cover ARM64 selecting Apple_silicon, ARM64 fallback to Universal, Intel selecting Universal, and Intel edge case
- Replace Date() with Date(timeIntervalSince1970: 0) for consistent test behavior - Replace force unwraps with XCTUnwrap in test mocks - Replace try! with try and proper error handling - Wrap mock setup in do-catch blocks that return Promise errors
acecilia
commented
Jan 16, 2026
| } else { | ||
| // On Intel, prefer Universal, avoid Apple_silicon | ||
| selected = variants.first { $0.url.absoluteString.contains("Universal") } | ||
| ?? variants.first { !$0.url.absoluteString.contains("Apple_silicon") } |
Author
There was a problem hiding this comment.
Datasource does not include an arch parameter, so the only way to distinguish is by using the file name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #456
Tested on my intel mac: after running
update, I was able to runinstall 26.2and it installed the correct architecture