Rename saved files #180
Merged
Rename saved files #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now place the kind name first, which makes more sense imho. We also use (stem, homological degree) notation instead of (homological degree, internal degree), which makes it easier to inspect. To avoid negative signs, we replace minuses by the character `m`.
Collaborator
Author
My pleasure! I changed the target branch to |
JoeyBF
added a commit
that referenced
this pull request
Jan 30, 2025
* Rename save files themselves We now use (stem, homological degree) notation instead of (homological degree, internal degree) in the names of files, which makes them easier to inspect. To avoid dashes in filenames, we replace minuses by the character m. * Adjust tests
JoeyBF
added a commit
to JoeyBF/sseq
that referenced
this pull request
Feb 2, 2025
* Rename save files themselves We now use (stem, homological degree) notation instead of (homological degree, internal degree) in the names of files, which makes them easier to inspect. To avoid dashes in filenames, we replace minuses by the character m. * Adjust tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now use (stem, homological degree) notation instead of (homological degree, internal degree) in the names of files, which makes them easier to inspect. To avoid dashes in filenames, we replace minuses by the character
m.This is the change that I mentioned in #127 (comment).