-
Notifications
You must be signed in to change notification settings - Fork 12
Add util to build balanced range partition book #434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/unit_test_py |
|
/integration_test |
|
/e2e_test |
GiGL Automation@ 20:05:35UTC : 🔄 @ 21:11:58UTC : ✅ Workflow completed successfully. |
GiGL Automation@ 20:05:40UTC : 🔄 |
GiGL Automation@ 20:05:43UTC : 🔄 @ 21:28:57UTC : ❌ Workflow failed. |
|
/unit_test_py |
|
/integration_test |
|
/e2e_test |
GiGL Automation@ 23:55:11UTC : 🔄 @ 01:01:59UTC : ✅ Workflow completed successfully. |
GiGL Automation@ 23:55:16UTC : 🔄 @ 24:47:09UTC : ✅ Workflow completed successfully. |
GiGL Automation@ 23:55:18UTC : 🔄 @ 01:13:01UTC : ✅ Workflow completed successfully. |
mkolodner-sc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Kyle! Left a few small comments but generally LGTM
Scope of work done
Doing this mainly so I can leverage the exact same logic for the GS integration test :P
We can't use this for the edges, as they are not guaranteed to be evenly balanced, as they are sharded by src node id.
Where is the documentation for this feature?: N/A
Did you add automated tests or write a test plan?
Updated Changelog.md? NO
Ready for code review?: NO