-
Notifications
You must be signed in to change notification settings - Fork 0
Add sidebar to dashboard and fix broken /notes route #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: loro-redo
Are you sure you want to change the base?
Conversation
…design sidebar UI, and update editor toolbar tool group structure.
lishaduck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This genuinely makes me a little mad. Not much. I was much worse earlier when "oh the llm broke the project". But still a little.
But I am proud of the committing habits. I assume Gemini picked up from your Claude, but perhaps you're improving. Given that the AGENTS.md told the to quit it, I'll give you the benefit of the doubt.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert this, it's wrong.
src/routes/+layout.svelte
Outdated
| // Keyboard shortcut: Ctrl+B (or Cmd+B on Mac) | ||
| const handleKeydown = (e: KeyboardEvent) => { | ||
| if ((e.ctrlKey || e.metaKey) && e.key === "b") { | ||
| e.preventDefault(); | ||
| toggleSidebar(); | ||
| } | ||
| }; | ||
| window.addEventListener("keydown", handleKeydown); | ||
| return () => { | ||
| window.removeEventListener("resize", handleResize); | ||
| window.removeEventListener("keydown", handleKeydown); | ||
| }; | ||
| }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No way José
src/routes/+layout.svelte
Outdated
| $effect(() => { | ||
| localStorage.setItem("sidebarCollapsed", String(isCollapsed)); | ||
| }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use runed's PersistedState plz... 🙏🏻
Really, we need to refactor all of our UI state to use Runed, but I can at least stop too much more from leaking in here.
| </script> | ||
|
|
||
| <div class="min-h-screen bg-base-100 p-8"> | ||
| <div class="h-full bg-base-100 p-8"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch lil' bot!
Authored-by: @PetalCat
Authored-by: @gemini-code-assist