refactor: optimize test suite (143 → 77 tests) #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ogic ## Summary 143 → 77 tests (46% reduction) while maintaining quality coverage ## Tests Removed (by category) ### Trivial Type/Existence Tests - "should be a non-empty string" for constants - "should return a number" for generateId - "returns an array" for getProviderPresets - Type checking tests covered by TypeScript ### Duplicate Coverage - 8 individual provider tests → 1 representative test - Multiple placeholder tests → consolidated into one - Redundant singleton pattern tests ### Language Feature Tests - Array.join behavior - Set deduplication - Immutability verification ### Constant Verification Tests - Tests checking if constant equals itself - Template section existence tests ## Tests Kept (business logic focus) ### API Tests - Provider routing and response parsing - Error handling (HTTP 4xx, 5xx) - Placeholder replacement logic ### Frontmatter Tests - Field value collection across files - Tags special handling (inline vs frontmatter) - WikiLink format conversion - Overwrite vs append behavior ### Utils Tests - Provider preset matching logic - Case sensitivity behavior - Fallback to "Custom Provider" 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add missing TFile properties (name, extension, stat, vault, parent) - Create createMockTFile factory function for proper instantiation - Use type assertions (as any) for mock objects in test functions - Import mock helpers directly from __mocks__/obsidian.ts 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
143 → 77 tests (46% reduction) while maintaining quality coverage
🗑️ Tests Removed
Trivial Type/Existence Tests
should be a non-empty stringshould return a numberreturns an arrayDuplicate Coverage
Language Feature Tests (Not Our Code)
Array.join()behaviorSetdeduplicationConstant Self-Verification
DEFAULT_SYSTEM_ROLEcontains "JSON" (it always will)✅ Tests Kept (Business Logic)
API Layer
Frontmatter
Utils
Test Results
🤖 Generated with Claude Code