fix: resolve count undefined bug and improve count UX with slider #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add model selection dropdown at top of Models section - Remove toggle from model list, keep management buttons only - Show checkmark (✓) next to currently selected model - Add empty state message when no models configured - Dropdown shows model name with provider: "GPT-4o (OpenAI)" This improves UX by using the correct UI pattern for single selection (dropdown) instead of toggles which are meant for on/off states. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
GoBeromsu
force-pushed
the
fix/count-undefined-and-slider-ux
branch
12 times, most recently
from
c59ff32 to
7c77b96
Compare
Bug fix: - Add settings migration in loadSettings() to ensure frontmatter items have proper defaults for count property - Prevents "undefined-undefined" display for old settings UX improvement: - Replace min/max range input with single slider (1-10) - Show current value next to slider instead of description - Add separator line between Maximum Count and Available Options - Display changed from "Count: 1-5" to "Max: 5" 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
GoBeromsu
force-pushed
the
fix/count-undefined-and-slider-ux
branch
from
7c77b96 to
d21e16e
Compare
Chain textareas to their parent Settings instead of creating separate Setting elements, maintaining proper visual hierarchy. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Wrap label Setting and TextArea in a shared setting-item container for proper visual grouping with generous textarea space. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Remove setting-item wrapper and add textarea directly to container with width: 100% for proper vertical layout. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
countcould be undefined for old settingsBug Fix
Old settings saved without
countproperty caused "undefined-undefined" display. Added migration logic inloadSettings()to ensure all frontmatter items have proper defaults.UX Improvement
Before:
After:
minis always 1, onlymaxis configurableTest plan
🤖 Generated with Claude Code