Skip to content

Conversation

@strub
Copy link
Member

@strub strub commented Jan 12, 2026

Check modules in types + properly classify declared modules as declared

@strub strub requested a review from oskgo January 12, 2026 14:09
@strub strub self-assigned this Jan 12, 2026
@strub strub added the bug label Jan 12, 2026
@strub strub linked an issue Jan 12, 2026 that may be closed by this pull request
@strub strub enabled auto-merge (rebase) January 12, 2026 14:09
@oskgo
Copy link
Contributor

oskgo commented Jan 12, 2026

It seems to me like the module case should be made to work rather than prevented. What do you think? I think it's fine to prevent it as a short term solution, but I want to make sure that this is being done deliberately.

@strub
Copy link
Member Author

strub commented Jan 12, 2026

It seems to me like the module case should be made to work rather than prevented. What do you think? I think it's fine to prevent it as a short term solution, but I want to make sure that this is being done deliberately.

Currently, the code does not generalise declared module in modules. So the check should be fixed w.r.t. that behaviour. Then, we can have a subsequent feature request for this.

@alleystoughton
Copy link
Member

This change is breaking some of my EasyUC proofs.

@alleystoughton
Copy link
Member

Actually, I seem to have left out a local. I'll report back.

@alleystoughton
Copy link
Member

Yes, false alarm. All good from my end.

Check modules in types + properly classify declared modules as declared
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Declared modules can improperly leak into modules and operators

4 participants