fix: Theme Builder - recover from sass update #32227
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a compatibility issue with sass-embedded 1.97.1 by downgrading to version 1.93.3 and implementing a defensive fix for color channel value handling. The issue appears to be that sass-embedded 1.97.1 returns color channel values outside the valid 0-255 range after certain color manipulation operations (like color.adjust()), causing incorrect hex color generation.
Changes:
- Downgraded sass-embedded from 1.97.1 to 1.93.3 in three packages (devextreme, devextreme-themebuilder, devextreme-scss)
- Added bounds clamping (0-255) and rounding to color channel values in parse-value.ts to ensure valid hex color output
- Updated tests to include
$float-channel-colorvariable that usescolor.adjust()to verify the fix works correctly
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Updated dependency lockfile with sass-embedded 1.93.3 and all platform-specific packages |
| packages/devextreme/package.json | Downgraded sass-embedded from 1.97.1 to 1.93.3 in devDependencies |
| packages/devextreme-themebuilder/package.json | Downgraded sass-embedded from 1.97.1 to 1.93.3 in dependencies |
| packages/devextreme-scss/package.json | Downgraded sass-embedded from 1.97.1 to 1.93.3 in devDependencies |
| packages/devextreme-themebuilder/src/modules/parse-value.ts | Added bounds clamping and rounding to color channel values to handle out-of-range values from sass color functions |
| packages/devextreme-themebuilder/tests/modules/compiler.test.ts | Added expected $float-channel-color value to test color.adjust() handling |
| packages/devextreme-themebuilder/tests/modules/compile-manager.test.ts | Added expected $float-channel-color value to compilation metadata test |
| packages/devextreme-themebuilder/tests/data/scss/widgets/generic/_colors.scss | Added $float-channel-color variable using color.adjust() to test color manipulation |
| packages/devextreme-themebuilder/tests/data/compilation-results/no-changes-meta.ts | Added $float-channel-color to baseline metadata expectations |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
GoodDayForSurf
approved these changes
Jan 16, 2026
ajivanyandev
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.