Scheduler - Appointment Form - Fix KBN issues #32225
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tucchhaa
commented
Jan 16, 2026
| private createRecurrenceRuleGroup(): GroupItem { | ||
| // Change of frequency editor's value causes rerender of the recurrencePatternGroup. | ||
| // To prevent focus loss in this editor, we use this flag. | ||
| let needRestoreFrequencyEditorFocus = false; |
Contributor
Author
There was a problem hiding this comment.
The reason of focus loss is because recurrencePatternGroup group gets rerendered when updateDayEditorsVisibility() is called.
Another solution is to wrap weekGroup, monthGroup and yearGroup into different group here.
I have decided to use this flag, because it's used in very narrow scope and because form items already have very deep nesting (docs).
But if you have any objections, let's discuss it :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.