Added EntityTag.State Property for Armadillo Rolling #2802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tal5
requested changes
Jan 12, 2026
Comment on lines
519
to
521
| public ElementTag getArmadilloState(Armadillo entity) { | ||
| throw new UnsupportedOperationException(); | ||
| } |
Member
There was a problem hiding this comment.
Should create an "API" enum of our own and take/return that (see for example BlockHelper#get/setPushReaction), that way we don't directly depend on Mojang's internal enum names and can easily notice once there's changes and/or avoid them entirely because we control the naming.
|
|
||
| @Override | ||
| public void setPropertyValue(ElementTag param, Mechanism mechanism) { | ||
| NMSHandler.entityHelper.setArmadilloState(as(Armadillo.class), mechanism, param); |
Member
There was a problem hiding this comment.
Once we have our own enum, can handle input checking here instead of in each NMS impl
|
|
||
| @Override | ||
| public ElementTag getArmadilloState(org.bukkit.entity.Armadillo entity) { | ||
| net.minecraft.world.entity.animal.armadillo.Armadillo armadillo = (Armadillo) ((CraftEntity) entity).getHandle(); |
Member
There was a problem hiding this comment.
Why are you using the FQN here if you have it imported & use it normally in the cast?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redo of #2758 using NMS rather than Spigot's method.