-
Notifications
You must be signed in to change notification settings - Fork 9
Improve connection settings UI #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
moralpriest
wants to merge
11
commits into
DEROFDN:dev
Choose a base branch
from
moralpriest:feature/connection-settings
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace 25 individual word entries with single multi-line seed entry - Add paste from clipboard button with icon - Implement word validation with specific error messages - Remove language dropdown from Recovery Words mode - Simplify UI with cleaner labels and headings - Fix nil pointer crash in FocusGained callback - Fix nested scroll container causing UI freeze - Remove 'an existing' from recovery text on main page - Fix for Cyberdeck initial settings
- Add validation error display for custom node entry when connection fails - Fix closure bug in node list where loop variable was captured incorrectly - Load and persist custom nodes per network (mainnet/testnet/simulator) - Save node list when removing nodes so changes persist - Fix empty input validation for blocks scan entry - Remove unused entryAddress widget and simplify code - Extract getNodesKey helper to reduce code duplication - Simplify entryScan validator by removing redundant SetValidationError calls - Clean up labelBack.OnTapped by removing redundant network setting
- Disable remove button when only one node remains - Add guard in callback to prevent removal of last node - Fix daemon selection when removing the currently connected node - Check both connection status and daemon address when determining if removed node was active
- Add confirmation dialogs for Restore Defaults and Clear Local Data - Restore Defaults now also resets node list and clears RPC credentials - Add RPC username/password persistence across sessions - Remove unused frame variable and redundant checkbox code
- Simplify radioNetwork.OnChanged logic - Move block scan side effect from validator to OnChanged - Clean up Gnomon checkbox initialization - Refactor node key logic into reusable helper functions - Simplify network selection with switch statement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of changes:
This PR introduces significant improvements to the connection settings UI and refactors the wallet recovery flow for a better user experience.
Connection Settings Improvements
Other Improvements
Type of change
Which part is impacted ?
Checklist:
License
I am contributing & releasing the code under RESEARCH LICENSE (which can be found here).