Skip to content

Conversation

@Avdhesh-Varshney
Copy link
Collaborator

Pull Requests Review Criteria

Caution

PRs that fail to meet these review standards will be automatically flagged and may be rejected by maintainers.

  • Filled out this PR template properly
  • Did not commit directly to main
  • Limited commits (max 3–4 unless permitted by Admin/Mentors)
  • Added comments in complex parts of code

Describe the add-ons or changes you've made 📃

  • Move app directory from modules to src folder
  • Update search functionality for users & projects with responsiveness

@Avdhesh-Varshney Avdhesh-Varshney self-assigned this Jan 17, 2026
@Avdhesh-Varshney Avdhesh-Varshney added the enhancement New feature or request label Jan 17, 2026
@vercel
Copy link

vercel bot commented Jan 17, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
code-a2z Ready Ready Preview, Comment Jan 18, 2026 5:43pm
code-a2z-server Ready Ready Preview, Comment Jan 18, 2026 5:43pm

@github-actions
Copy link

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the search functionality and restructures the application by moving the app directory from modules to the src level. The search feature has been reimplemented to work as a query parameter-based module within the home page, replacing the previous route-based approach. The changes introduce a more integrated search experience with improved state management.

Changes:

  • Relocated app directory from modules/app to src/app with corresponding import path updates across 20+ files
  • Replaced the standalone /search/:query route with a query parameter-based search (?searchTerm=...) integrated into the home page
  • Extracted home page content into a separate HomeContent component for better code organization
  • Enhanced Navbar component to support external search state management through props

Reviewed changes

Copilot reviewed 33 out of 36 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
client/src/app/routes/* Newly moved app routing infrastructure with updated relative imports
client/src/app/components/index.tsx Updated component lazy loading paths to reflect new module structure
client/src/modules/home/v1/index.tsx Refactored to conditionally render search or home content based on query params
client/src/modules/home/v1/hooks/index.ts Added searchTerm and activeModule state management using query parameters
client/src/modules/home/v1/components/index.tsx New HomeContent component extracted from main home page
client/src/modules/home/routes/index.tsx Renamed function to HOME_ROUTES and added HOME_QUERY_PARAMS enum
client/src/modules/home/modules/search/v1/* New search module implementation with dedicated hooks and components
client/src/modules/search/* Old search module removed completely
client/src/shared/components/organisms/navbar/* Enhanced to support controlled search state from parent components
client/src/modules/settings/* Updated imports to reference relocated app directory
client/src/modules/notification/* Updated imports to reference relocated app directory
client/src/modules/manage-projects/* Updated imports to reference relocated app directory
client/src/App.tsx Updated import paths for relocated app routing modules

@Avdhesh-Varshney
Copy link
Collaborator Author

@copilot open a new pull request to apply changes based on the comments in this thread

Copy link
Contributor

Copilot AI commented Jan 17, 2026

@Avdhesh-Varshney I've opened a new pull request, #1351, to work on those changes. Once the pull request is ready, I'll request review from you.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 41 out of 45 changed files in this pull request and generated 5 comments.

Comments suppressed due to low confidence (1)

client/src/shared/components/organisms/header/hooks/index.ts:79

  • The useEffect hook is missing triggerSearchByKeyboard in its dependency array. This function is defined inside the component and uses isDesktop and searchInputRef, so it should either be added to the dependencies or wrapped in a useCallback hook to ensure the effect has stable dependencies.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@Avdhesh-Varshney Avdhesh-Varshney merged commit c46ebc4 into main Jan 18, 2026
4 checks passed
@Avdhesh-Varshney Avdhesh-Varshney deleted the avdhesh/home/search-editor-routes branch January 18, 2026 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants