[client-v2] Send parameters in request body #2713
Open
+208
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion stream to proper handle resources.
…e flag - false by default
Client V2 CoverageCoverage Report
Class Coverage
|
JDBC V2 CoverageCoverage Report
Class Coverage
|
|
JDBC V1 CoverageCoverage Report
Class Coverage
|
Client V1 CoverageCoverage Report
Class Coverage
|
kavirajk
approved these changes
Jan 16, 2026
kavirajk
left a comment
kavirajk
left a comment
There was a problem hiding this comment.
LGTM (given my limited Java knowledge 😆 )
Left few minor comments. Approving to unblock
| * If parameters should be sent in request body. | ||
| * Note: work only with HTTP Compression | ||
| */ | ||
| USE_HTTP_FORM_REQUEST_FOR_QUERY("client.http.use_form_request_for_query", Boolean.class, "false"), |
There was a problem hiding this comment.
suggestion: Can we name the config HTTP_SEND_PARAMS_IN_BODY instead? Not sure if there are any standard way to name these in java client. But just looking at it, made me confuse. Mainly FOR_QUERY is too generic and no where it says about parameters?.
or USE_HTTP_FORM_REQUEST_FOR_QUERY_PARAMS but I felt that is bit too mouthful. Given it's a boolean we can avoid USE_ prefix I think.
Contributor
Author
There was a problem hiding this comment.
Sounds good!
I struggle to find good names sometimes.
| @Override | ||
| public long getContentLength() { | ||
| return httpEntity.getContentLength(); | ||
| // compressed request length is unknown event if it is a byte[] |
|
|
||
| /** | ||
| * If parameters should be sent in request body. | ||
| * Note: work only with HTTP Compression |
There was a problem hiding this comment.
does it works with both HTTP compression and block level compression?
Contributor
Author
There was a problem hiding this comment.
It works for server side compression only. I will rephrase the comment.
It doesn't work with client side compression because requires to compress each parameter what would be expensive.
| params); | ||
| fail("exception expected"); | ||
| } catch (Exception e) { | ||
| e.printStackTrace(); |
There was a problem hiding this comment.
Not sure if this is used for debugging. and should be replaced with throw instead of print?
Contributor
Author
There was a problem hiding this comment.
yes, in general it should be logged or thrown. Using printStackTrace is not good. Even in tests we have org.testng.Assert#fail(java.lang.String, java.lang.Throwable).
I've changed code so this test branch is positive now.
Contributor
Author
|
Thank you, @kavirajk ! I appreciate your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
USE_HTTP_FORM_REQUEST_FOR_QUERYCloses #2324
Checklist
Delete items not relevant to your PR:
Note
Introduces HTTP form-data support for query parameters and refactors HTTP transport/compression for cleaner APIs.
USE_HTTP_FORM_REQUEST_FOR_QUERYand builder methoduseHttpFormDataForQuery(...)to sendstatement_paramsin request body for query operationsHttpAPIClientHelper(executeMultiPartRequest) and a string-bodyexecuteRequest(..., String); factors URI/context/header building; pools venting extractedLZ4FactoryinsideHttpAPIClientHelper; updates call sites to drop passing it per-callgetContentLength()reporting (-1) and ensure proper stream closing inCompressedEntity/LZ4Entitylz4Factory; route query with params to multipart when enabled; minor logging target changestestMultiPartRequest; update default config size assertions (+1)Written by Cursor Bugbot for commit 4611d05. This will update automatically on new commits. Configure here.