feat(abstract-utxo): deprecate network for AbstractUtxoCoin internally
#7891
+220
−165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify the signature of isReplayProtectionUnspent to accept any object with an address property instead of requiring a full utxolib unspent. Issue: BTC-2916 Co-authored-by: llm-git <llm-git@ttll.de>
This commit refactors the code to use coin name strings instead of utxolib network objects when interacting with addresses, descriptors, and other coin-specific functionality. This makes the code more maintainable and helps in the transition to wasm-utxo. Also adds utility functions isTestnetCoin and isMainnetCoin to replace the utxolib functions. Issue: BTC-2916 Co-authored-by: llm-git <llm-git@ttll.de>
OttoAllmendinger
changed the title
network for AbstractUtxoCoinnetwork for AbstractUtxoCoin internally
davidkaplanbitgo
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two main improvements to the abstract-utxo package:
Simplifies the signature of isReplayProtectionUnspent to accept any object
with an address property instead of requiring a full utxolib unspent.
Refactors the code to use coin name strings instead of utxolib network
objects when interacting with addresses, descriptors, and other
coin-specific functionality. This makes the code more maintainable and
helps in the transition to wasm-utxo.
Also adds utility functions isTestnetCoin and isMainnetCoin to replace
the utxolib functions.
Issue: BTC-2916