Skip to content

Conversation

@andystaples
Copy link
Contributor

Allows configuring this setting after initializing AzureStorageOrchestrationService to allow post-config by extension based on worker indexing results

Copilot AI review requested due to automatic review settings January 15, 2026 19:03
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a public setter method SetUseSeparateQueueForEntityWorkItems to allow post-initialization configuration of the UseSeparateQueueForEntityWorkItems setting based on worker indexing results, and bumps the patch version from 2.8.0 to 2.8.1.

Changes:

  • Added public method SetUseSeparateQueueForEntityWorkItems to allow modification of the entity work items queue separation setting after service initialization
  • Incremented patch version from 2.8.0 to 2.8.1

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File Description
src/DurableTask.AzureStorage/DurableTask.AzureStorage.csproj Version bump from 2.8.0 to 2.8.1
src/DurableTask.AzureStorage/AzureStorageOrchestrationService.cs Added new public method to allow post-initialization modification of UseSeparateQueueForEntityWorkItems setting

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

/// Sets the value for settings.UseSeparateQueueForEntityWorkItems, allowing modification after initialization.
/// </summary>
/// <param name="newValue"></param>
public void SetUseSeparateQueueForEntityWorkItems(bool newValue)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we just make this a get/set property?

Suggested change
public void SetUseSeparateQueueForEntityWorkItems(bool newValue)
public bool UseSeparateQueueForEntityWorkItems
{
get => this.settings.UseSeparateQueueForEntityWorkItems;
set => this.UseSeparateQueueForEntityWorkItems = value;
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea - added

@andystaples andystaples merged commit 77af69d into main Jan 15, 2026
46 checks passed
@andystaples andystaples deleted the andystaples/storage-config-entity-setting-change branch January 15, 2026 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants