25.8.14 Backport of #88090: Optimize ReplacingMergeTree is_deleted FINAL queries by adding a filter expression transform #1304
+112
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with_filter Optimize ReplacingMergeTree is_deleted FINAL queries by adding a filter expression transform
| columns_with_is_deleted.push_back(data.merging_params.is_deleted_column); | ||
|
|
||
| pipe = spreadMarkRangesAmongStreams( | ||
| std::move(non_intersecting_parts_by_primary_key), index_build_context, num_streams, columns_with_is_deleted); |
Collaborator
There was a problem hiding this comment.
index_build_context is not present in the same backport on 25.8.13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
SELECT query with
FINALclause on aReplacingMergeTreetable with theis_deletedcolumn now executes faster because of improved parallelization from 2 existing optimizations (ClickHouse#88090 by @shankar-iyer)CI/CD Options
Exclude tests:
Regression jobs to run: