Skip to content

Conversation

@anishravi
Copy link
Collaborator

…updates, and add new UI components for modals, headers, and avatars.

…updates, and add new UI components for modals, headers, and avatars.
@anishravi anishravi requested a review from ATS527 January 17, 2026 16:05
@anishravi anishravi self-assigned this Jan 17, 2026

const settingsSchema = z.object({
name: z.string().min(3, "Name must be at least 3 characters"),
name: z.optional(z.string().min(3, "Name must be at least 3 characters")),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this optional in name

<View className="mr-4 flex-row items-center gap-4">
<TouchableOpacity onPress={handleToggleTheme}>
{colorScheme === "dark" ? (
<Moon size={24} className="text-foreground" color="#FFFFFF" />
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this dark mode and logout to settings page. As the user is not going to frequently logout of the application.

@@ -0,0 +1,27 @@
import { useRouter } from "expo-router";
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the system default back button here. Research if it is needed in web

@@ -1,26 +1,38 @@
import { zodResolver } from "@hookform/resolvers/zod";
import { useMutation, useQuery } from "convex/react";
import * as ImagePicker from "expo-image-picker";
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactor this file

export const authSchema = z.object({
email: z.email("Please enter a valid email address"),
const signInSchema = z.object({
email: z.string().email("Please enter a valid email address"),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

string().email() is deprecated. revert back

const signInSchema = z.object({
email: z.string().email("Please enter a valid email address"),
password: z.string().min(8, "Password must be at least 8 characters"),
name: z.string().optional(),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we dont need name here right

name: z.string().min(2, "Name is required"),
});

export type AuthFormData = z.infer<typeof signUpSchema>;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolver is using same schema for both sign in and sign up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants