-
Notifications
You must be signed in to change notification settings - Fork 180
Open
Description
I noticed in much of the code where I use progress, I also give some feedback about throughput and duration.
I tried to recode this so that I was delegating this to the Progress/Infinite object, but two basic problems prevented this:
- The elapsed property is cast to int so that it cannot be used for accurate duration and throughput calculations
- The "timer" keeps running after the progress has been finished.
A solution to both is as follows:
- use
monotonic()when finish method is called and initialize an attribute calledend_ts - add a
durationattribute that returnsself.end_ts - self.start_ts, and is not cast to int - document that users should used duration rather than elapsed
I also wonder whether you should switch to perf_counter() from monotonic() at this point, but I am not sure whether in CPython or pypy there is any practical difference.
Metadata
Metadata
Assignees
Labels
No labels