README: Recommend using Promise.try() in Error Handling section

[mwolson]

One of the emerging best practices around Bluebird Promises is to use promise.try() per the blog post here: http://cryto.net/~joepie91/blog/2016/05/11/what-is-promise-try-and-why-does-it-matter/

Instead of instructing people (somewhat briefly and confusingly) to use .catch() in the "Error Handling" section of README.md, it would be better to include an example along the lines of those in the above blog post which uses Promise.try()

[oliverturner]

The Bluebird library has been dropped:

• Promises are natively supported in all current versions of Node
• Bluebird adds unacceptable bloat to the generated bundle: the output was ~750kb vs 15kb without.
• Client-side consumers are free to use their own choice of polyfill where they need to support browsers that need it.

[adammeghji]

@oliverturner this is a new concept to me, but the article claims this is a good idea even with native ES6 promises:

1. Better error handling; synchronous errors are propagated as rejections, no matter where in the process they occur.
2. Better interoperability; no matter what Promises implementation the third-party method uses, you will always be working with your preferred implementation.
3. Easier to 'scan'; all code is horizontally at the same indentation level, so it's easier to see what's going on at a glance.

Should we consider adding this to our native Promise usage now (post-Bluebird)?

[oliverturner]

Adding it would inject non-standard (albeit proposed) behaviour via a 3rd party dependency; I'd counsel against doing that internally and leave it to the consuming app to implement if desired.

If the proposal proceeds beyond stage-0 I'd happily reconsider my position.

Would an example of how to implement in the documentation suffice in the meantime?

[adammeghji]

@oliverturner great idea re: examples, perhaps we could have an "examples/" folder, incl. a node and a web example. Might be a good way to demo some best practices, incl. this suggestion.

[oliverturner]

well there's already the /docs folder that contains some bare-bones examples in exactly that structure: node & web, and my last PR keeps the web version automatically updated with the release.

Completely agree though, that there's ample scope for more & richer examples plus commentary on Best Practice™ and that this topic is a rich one for discussion :)

[adammeghji]

@oliverturner 😳 very true! /docs does exist. I think they're stale now :) we'll update in a separate Issue. Let's leave this open and incorporate the suggestion into:
https://github.com/ticketmaster-api/sdk-javascript/blob/master/docs/test.js (for example)