Increment watch version only on actual modifications (#1434)

* fix

* fixes

* format

* update version

* fix

* Bump version to 1.0.89

Author: badrishc

Version.props

@@ -1,6 +1,6 @@
 <Project>
 	<!-- VersionPrefix property for builds and packages -->
 	<PropertyGroup>
-		<VersionPrefix>1.0.87</VersionPrefix>
+		<VersionPrefix>1.0.89</VersionPrefix>
 	</PropertyGroup>
 </Project>

libs/server/Storage/Functions/MainStore/PrivateMethods.cs

@@ -274,7 +274,7 @@ void CopyRespToWithInput(ref RawStringInput input, ref SpanByte value, ref SpanB
             }
         }
 
-        bool EvaluateExpireInPlace(ExpireOption optionType, bool expiryExists, long newExpiry, ref SpanByte value, ref SpanByteAndMemory output)
+        IPUResult EvaluateExpireInPlace(ExpireOption optionType, bool expiryExists, long newExpiry, ref SpanByte value, ref SpanByteAndMemory output)
         {
             ObjectOutputHeader* o = (ObjectOutputHeader*)output.SpanByte.ToPointer();
             if (expiryExists)
@@ -291,26 +291,26 @@ bool EvaluateExpireInPlace(ExpireOption optionType, bool expiryExists, long newE
                         break;
                     case ExpireOption.GT:
                     case ExpireOption.XXGT:
-                        var replace = newExpiry < value.ExtraMetadata;
-                        value.ExtraMetadata = replace ? value.ExtraMetadata : newExpiry;
+                        var replace = newExpiry > value.ExtraMetadata;
+                        if (replace) value.ExtraMetadata = newExpiry;
                         if (replace)
-                            o->result1 = 0;
-                        else
                             o->result1 = 1;
+                        else
+                            o->result1 = 0;
                         break;
                     case ExpireOption.LT:
                     case ExpireOption.XXLT:
-                        replace = newExpiry > value.ExtraMetadata;
-                        value.ExtraMetadata = replace ? value.ExtraMetadata : newExpiry;
+                        replace = newExpiry < value.ExtraMetadata;
+                        if (replace) value.ExtraMetadata = newExpiry;
                         if (replace)
-                            o->result1 = 0;
-                        else
                             o->result1 = 1;
+                        else
+                            o->result1 = 0;
                         break;
                     default:
                         throw new GarnetException($"EvaluateExpireInPlace exception expiryExists:{expiryExists}, optionType{optionType}");
                 }
-                return true;
+                return o->result1 == 1 ? IPUResult.Succeeded : IPUResult.NotUpdated;
             }
             else
             {
@@ -319,13 +319,13 @@ bool EvaluateExpireInPlace(ExpireOption optionType, bool expiryExists, long newE
                     case ExpireOption.NX:
                     case ExpireOption.None:
                     case ExpireOption.LT:  // If expiry doesn't exist, LT should treat the current expiration as infinite
-                        return false;
+                        return IPUResult.Failed;
                     case ExpireOption.XX:
                     case ExpireOption.GT:
                     case ExpireOption.XXGT:
                     case ExpireOption.XXLT:
                         o->result1 = 0;
-                        return true;
+                        return IPUResult.NotUpdated;
                     default:
                         throw new GarnetException($"EvaluateExpireInPlace exception expiryExists:{expiryExists}, optionType{optionType}");
                 }