From 510fdfdf6d2c414527957481732bb23d192d8cc2 Mon Sep 17 00:00:00 2001
From: William Allen <william.allen@kitware.com>
Date: Sun, 18 Jan 2026 12:50:09 -0500
Subject: [PATCH] Revamp project creation page

---
 .../Controllers/CreateProjectController.php   |  20 ++
 app/cdash/app/Model/Project.php               |   2 +-
 app/cdash/tests/CMakeLists.txt                |   2 +
 config/cdash.php                              |   1 +
 ...18_161331_nullable_project_description.php |  16 ++
 graphql/schema.graphql                        |   4 +-
 resources/js/vue/app.js                       |   2 +
 .../js/vue/components/CreateProjectPage.vue   | 239 ++++++++++++++++++
 routes/web.php                                |   3 +-
 tests/Browser/Pages/CreateProjectPageTest.php | 164 ++++++++++++
 10 files changed, 449 insertions(+), 4 deletions(-)
 create mode 100644 app/Http/Controllers/CreateProjectController.php
 create mode 100644 database/migrations/2026_01_18_161331_nullable_project_description.php
 create mode 100644 resources/js/vue/components/CreateProjectPage.vue
 create mode 100644 tests/Browser/Pages/CreateProjectPageTest.php

diff --git a/app/Http/Controllers/CreateProjectController.php b/app/Http/Controllers/CreateProjectController.php
new file mode 100644
index 0000000000..e6fd4cf30c
--- /dev/null
+++ b/app/Http/Controllers/CreateProjectController.php
@@ -0,0 +1,20 @@
+<?php
+
+namespace App\Http\Controllers;
+
+use App\Models\Project;
+use Illuminate\Http\Request;
+use Illuminate\Support\Facades\Gate;
+use Illuminate\View\View;
+
+final class CreateProjectController extends AbstractController
+{
+    public function __invoke(Request $request): View
+    {
+        Gate::authorize('create', Project::class);
+
+        return $this->vue('create-project-page', 'Create Project', [
+            'max-project-visibility' => $request->user()->admin ?? false ? 'PUBLIC' : config('cdash.max_project_visibility'),
+        ]);
+    }
+}
diff --git a/app/cdash/app/Model/Project.php b/app/cdash/app/Model/Project.php
index 713b903bf9..0a22968019 100644
--- a/app/cdash/app/Model/Project.php
+++ b/app/cdash/app/Model/Project.php
@@ -114,7 +114,7 @@ public function Save(): bool
         $project = EloquentProject::findOrNew($this->Id);
         $project->fill([
             'name' => $this->Name ?? '',
-            'description' => $this->Description ?? '',
+            'description' => $this->Description,
             'homeurl' => $this->HomeUrl ?? '',
             'cvsurl' => $this->CvsUrl ?? '',
             'documentationurl' => $this->DocumentationUrl ?? '',
diff --git a/app/cdash/tests/CMakeLists.txt b/app/cdash/tests/CMakeLists.txt
index e8ba0debca..4ae7a27844 100644
--- a/app/cdash/tests/CMakeLists.txt
+++ b/app/cdash/tests/CMakeLists.txt
@@ -332,6 +332,8 @@ add_browser_test(/Browser/Pages/ProjectMembersPageTest)
 
 add_browser_test(/Browser/Pages/ProjectBuildsPageTest)
 
+add_browser_test(/Browser/Pages/CreateProjectPageTest)
+
 add_browser_test(/Browser/Pages/ProjectsPageTest)
 set_property(TEST /Browser/Pages/ProjectsPageTest APPEND PROPERTY RUN_SERIAL TRUE)
 
diff --git a/config/cdash.php b/config/cdash.php
index 55014656f5..2ab98b606e 100755
--- a/config/cdash.php
+++ b/config/cdash.php
@@ -61,6 +61,7 @@
     'allow_submit_only_tokens' => env('ALLOW_SUBMIT_ONLY_TOKENS', true),
     'unlimited_projects' => $unlimited_projects,
     'user_create_projects' => env('USER_CREATE_PROJECTS', false),
+    // Options: PUBLIC, PROTECTED, PRIVATE
     // Defaults to public.  Only meaningful if USER_CREATE_PROJECT=true.
     'max_project_visibility' => env('MAX_PROJECT_VISIBILITY', 'PUBLIC'),
     'require_authenticated_submissions' => env('REQUIRE_AUTHENTICATED_SUBMISSIONS', false),
diff --git a/database/migrations/2026_01_18_161331_nullable_project_description.php b/database/migrations/2026_01_18_161331_nullable_project_description.php
new file mode 100644
index 0000000000..b15995f02d
--- /dev/null
+++ b/database/migrations/2026_01_18_161331_nullable_project_description.php
@@ -0,0 +1,16 @@
+<?php
+
+use Illuminate\Database\Migrations\Migration;
+
+return new class extends Migration {
+    public function up(): void
+    {
+        DB::statement('ALTER TABLE project ALTER COLUMN description DROP DEFAULT');
+        DB::statement('ALTER TABLE project ALTER COLUMN description DROP NOT NULL');
+        DB::update("UPDATE project SET description = NULL WHERE description = ''");
+    }
+
+    public function down(): void
+    {
+    }
+};
diff --git a/graphql/schema.graphql b/graphql/schema.graphql
index ec01dc2dd5..8a320f45d5 100644
--- a/graphql/schema.graphql
+++ b/graphql/schema.graphql
@@ -144,7 +144,7 @@ type Project {
   name: String! @filterable
 
   "Description."
-  description: String!
+  description: String
 
   "Homepage for this project."
   homeurl: Url @deprecated(reason: "Use 'homeUrl' instead.")
@@ -213,7 +213,7 @@ input CreateProjectInput {
   name: String! @rules(apply: ["App\\Rules\\ProjectNameRule"])
 
   "Description."
-  description: String!
+  description: String
 
   "Project homepage"
   homeurl: Url @deprecated(reason: "Use 'homeUrl' instead.") @rules(apply: ["prohibits:homeUrl"])
diff --git a/resources/js/vue/app.js b/resources/js/vue/app.js
index 0ec1f69312..5951bab886 100755
--- a/resources/js/vue/app.js
+++ b/resources/js/vue/app.js
@@ -32,6 +32,7 @@ const BuildTargetsPage = Vue.defineAsyncComponent(() => import('./components/Bui
 const BuildCommandsPage = Vue.defineAsyncComponent(() => import('./components/BuildCommandsPage.vue'));
 const CoverageFilePage = Vue.defineAsyncComponent(() => import('./components/CoverageFilePage.vue'));
 const BuildCoveragePage = Vue.defineAsyncComponent(() => import('./components/BuildCoveragePage.vue'));
+const CreateProjectPage = Vue.defineAsyncComponent(() => import('./components/CreateProjectPage.vue'));
 
 const cdash_components = {
   BuildConfigure,
@@ -59,6 +60,7 @@ const cdash_components = {
   BuildCommandsPage,
   CoverageFilePage,
   BuildCoveragePage,
+  CreateProjectPage,
 };
 
 const app = Vue.createApp({
diff --git a/resources/js/vue/components/CreateProjectPage.vue b/resources/js/vue/components/CreateProjectPage.vue
new file mode 100644
index 0000000000..d8a9d57184
--- /dev/null
+++ b/resources/js/vue/components/CreateProjectPage.vue
@@ -0,0 +1,239 @@
+<template>
+  <div
+    class="tw-flex tw-flex-row tw-w-full tw-justify-center"
+    data-test="create-project-page"
+  >
+    <div class="tw-w-full sm:tw-w-3/4 lg:tw-w-1/2 tw-flex tw-flex-col tw-gap-2">
+      <div
+        v-if="fatalError"
+        role="alert"
+        class="tw-alert tw-alert-error"
+      >
+        <font-awesome-icon
+          :icon="FA.faCircleXmark"
+          class="tw-h-6 tw-w-6"
+        />
+        <span>{{ fatalError }}</span>
+      </div>
+      <label class="tw-form-control tw-w-full">
+        <span class="tw-label tw-label-text tw-font-bold">
+          Project Name
+        </span>
+        <input
+          v-model="name"
+          type="text"
+          class="tw-input tw-input-bordered tw-w-full"
+          :class="{'tw-input-error': validationErrors.name}"
+          data-test="project-name-input"
+        >
+        <span
+          v-if="validationErrors.name"
+          class="tw-label tw-text-error"
+          data-test="project-name-validation-errors"
+        >
+          {{ validationErrors.name[0] }}
+        </span>
+      </label>
+      <label class="tw-form-control tw-w-full">
+        <span class="tw-label tw-label-textt tw-font-bold">
+          Description
+        </span>
+        <textarea
+          v-model="description"
+          class="tw-textarea tw-textarea-bordered tw-h-24 tw-w-full"
+          :class="{'tw-textarea-error': validationErrors.description}"
+          data-test="project-description-input"
+        />
+        <span
+          v-if="validationErrors.description"
+          class="tw-label tw-text-error"
+        >
+          {{ validationErrors.description[0] }}
+        </span>
+      </label>
+      <div class="tw-form-control tw-w-full">
+        <span class="tw-label tw-label-text tw-font-bold">
+          Visibility
+        </span>
+        <div class="tw-w-full tw-flex tw-flex-col tw-gap-1">
+          <label class="tw-flex tw-items-center tw-gap-2">
+            <input
+              v-model="visibility"
+              type="radio"
+              name="visibility"
+              class="tw-radio"
+              value="PUBLIC"
+              data-test="project-visibility-public"
+              :disabled="maxProjectVisibility === 'PRIVATE' || maxProjectVisibility === 'PROTECTED'"
+            >
+            <div>
+              <span class="tw-label-text">
+                <font-awesome-icon :icon="FA.faEarthAmericas" /> Public
+              </span>
+              <div class="tw-text-xs tw-text-neutral-500">
+                Does not require authentication to access.
+              </div>
+            </div>
+          </label>
+          <label class="tw-flex tw-items-center tw-gap-2">
+            <input
+              v-model="visibility"
+              type="radio"
+              name="visibility"
+              class="tw-radio"
+              value="PROTECTED"
+              data-test="project-visibility-protected"
+              :disabled="maxProjectVisibility === 'PRIVATE'"
+            >
+            <div>
+              <span class="tw-label-text">
+                <font-awesome-icon :icon="FA.faShieldHalved" /> Protected
+              </span>
+              <div class="tw-text-xs tw-text-neutral-500">
+                Access limited to authenticated users.
+              </div>
+            </div>
+          </label>
+          <label class="tw-flex tw-items-center tw-gap-2">
+            <input
+              v-model="visibility"
+              type="radio"
+              name="visibility"
+              class="tw-radio"
+              value="PRIVATE"
+              data-test="project-visibility-private"
+            >
+            <div>
+              <span class="tw-label-text">
+                <font-awesome-icon :icon="FA.faLock" /> Private
+              </span>
+              <div class="tw-text-xs tw-text-neutral-500">
+                Requires access to be granted explicitly.
+              </div>
+            </div>
+          </label>
+        </div>
+      </div>
+      <div class="tw-form-control tw-w-full">
+        <span class="tw-label tw-label-text tw-font-bold">
+          Submission Authentication
+        </span>
+        <label class="tw-flex tw-items-center tw-gap-2">
+          <input
+            v-model="requireAuthenticatedSubmissions"
+            type="checkbox"
+            class="tw-checkbox"
+            data-test="project-authenticated-submissions-input"
+          >
+          <span class="tw-label-text">
+            Require submissions to provide a valid authentication token.
+          </span>
+        </label>
+      </div>
+      <div class="tw-flex tw-justify-start tw-mt-4">
+        <button
+          class="tw-btn tw-btn-success"
+          data-test="create-project-button"
+          @click="createProject"
+        >
+          Create Project
+        </button>
+      </div>
+    </div>
+  </div>
+</template>
+
+<script>
+import {
+  faCircleXmark,
+  faEarthAmericas,
+  faShieldHalved,
+  faLock,
+} from '@fortawesome/free-solid-svg-icons';
+import {FontAwesomeIcon} from '@fortawesome/vue-fontawesome';
+import gql from 'graphql-tag';
+
+export default {
+  components: {FontAwesomeIcon},
+
+  props: {
+    maxProjectVisibility: {
+      type: String,
+      required: true,
+    },
+  },
+
+  data() {
+    return {
+      name: '',
+      description: '',
+      visibility: 'PRIVATE',
+      requireAuthenticatedSubmissions: false,
+      validationErrors: {},
+      fatalError: null,
+    };
+  },
+
+  computed: {
+    FA() {
+      return {
+        faCircleXmark,
+        faEarthAmericas,
+        faShieldHalved,
+        faLock,
+      };
+    },
+  },
+
+  methods: {
+    async createProject() {
+      this.validationErrors = {};
+      this.fatalError = null;
+      try {
+        const response = await this.$apollo.mutate({
+          mutation: gql`
+            mutation createProject($name: String!, $description: String, $visibility: ProjectVisibility!, $authenticateSubmissions: Boolean!) {
+              createProject(input: {
+                name: $name,
+                description: $description,
+                visibility: $visibility,
+                authenticateSubmissions: $authenticateSubmissions,
+              }) {
+                id
+              }
+            }
+          `,
+          variables: {
+            name: this.name,
+            description: this.description,
+            visibility: this.visibility,
+            authenticateSubmissions: this.requireAuthenticatedSubmissions,
+          },
+        });
+
+        if (response.data.createProject) {
+          window.location.href = `${this.$baseURL}/projects/${response.data.createProject.id}/edit`;
+        }
+      }
+      catch (error) {
+        if (error.graphQLErrors) {
+          error.graphQLErrors.forEach(e => {
+            if (e.extensions && e.extensions.validation) {
+              this.validationErrors = Object.keys(e.extensions.validation).reduce((acc, key) => {
+                acc[key.replace('input.', '')] = e.extensions.validation[key];
+                return acc;
+              }, {});
+            }
+            else {
+              this.fatalError = e.message;
+            }
+          });
+        }
+        else {
+          this.fatalError = error.message;
+        }
+      }
+    },
+  },
+};
+</script>
diff --git a/routes/web.php b/routes/web.php
index 5c6b93dfc2..5e6655a9e7 100755
--- a/routes/web.php
+++ b/routes/web.php
@@ -12,6 +12,7 @@
 */
 
 use App\Http\Controllers\CoverageFileController;
+use App\Http\Controllers\CreateProjectController;
 use App\Http\Controllers\GlobalInvitationController;
 use App\Http\Controllers\ProjectInvitationController;
 use App\Models\DynamicAnalysis;
@@ -163,7 +164,7 @@
     ->whereNumber('id');
 Route::permanentRedirect('/project/{id}/edit', url('/projects/{id}/edit'));
 
-Route::get('/projects/new', 'EditProjectController@create');
+Route::get('/projects/new', CreateProjectController::class);
 Route::permanentRedirect('/project/new', url('/projects/new'));
 
 Route::get('/projects/{id}/testmeasurements', 'ManageMeasurementsController@show')
diff --git a/tests/Browser/Pages/CreateProjectPageTest.php b/tests/Browser/Pages/CreateProjectPageTest.php
new file mode 100644
index 0000000000..d07c2e874b
--- /dev/null
+++ b/tests/Browser/Pages/CreateProjectPageTest.php
@@ -0,0 +1,164 @@
+<?php
+
+namespace Tests\Browser\Pages;
+
+use App\Models\Project;
+use App\Models\User;
+use Illuminate\Support\Str;
+use Laravel\Dusk\Browser;
+use PHPUnit\Framework\Attributes\DataProvider;
+use Tests\BrowserTestCase;
+use Tests\Traits\CreatesProjects;
+use Tests\Traits\CreatesUsers;
+
+class CreateProjectPageTest extends BrowserTestCase
+{
+    use CreatesProjects;
+    use CreatesUsers;
+
+    /**
+     * @var array<User>
+     */
+    private array $users = [];
+
+    /**
+     * @var array<Project>
+     */
+    private array $projects = [];
+
+    public function tearDown(): void
+    {
+        foreach ($this->users as $user) {
+            $user->delete();
+        }
+        $this->users = [];
+
+        foreach ($this->projects as $project) {
+            $project->delete();
+        }
+        $this->projects = [];
+
+        parent::tearDown();
+    }
+
+    public function testReturns403WhenInsufficientPermissions(): void
+    {
+        $this->users['normal'] = $this->makeNormalUser();
+        $this->users['admin'] = $this->makeAdminUser();
+
+        $this->browse(function (Browser $browser): void {
+            $browser->visit('/projects/new')
+                ->assertSee('This action is unauthorized.')
+            ;
+
+            $browser->loginAs($this->users['normal'])
+                ->visit('/projects/new')
+                ->assertSee('This action is unauthorized.')
+            ;
+
+            $browser->loginAs($this->users['admin'])
+                ->visit('/projects/new')
+                ->assertDontSee('This action is unauthorized.')
+            ;
+        });
+    }
+
+    public function testShowsErrorWhenInvalidProjectNameProvided(): void
+    {
+        $this->users['admin'] = $this->makeAdminUser();
+
+        $this->browse(function (Browser $browser): void {
+            $browser->loginAs($this->users['admin'])
+                ->visit('/projects/new')
+                ->waitFor('@create-project-page')
+                ->type('@project-name-input', 'invalid project name %')
+                ->click('@create-project-button')
+                ->waitFor('@project-name-validation-errors')
+                ->assertSeeIn('@project-name-validation-errors', 'Project name may only contain letters, numbers, dashes, and underscores.')
+            ;
+        });
+    }
+
+    public function testCreateProjectSetDescription(): void
+    {
+        $this->users['admin'] = $this->makeAdminUser();
+
+        $name = Str::uuid()->toString();
+        $description = Str::uuid()->toString();
+
+        $this->browse(function (Browser $browser) use ($description, $name): void {
+            $browser->loginAs($this->users['admin'])
+                ->visit('/projects/new')
+                ->waitFor('@create-project-page')
+                ->type('@project-name-input', $name)
+                ->type('@project-description-input', $description)
+                ->click('@create-project-button')
+                ->waitForReload()
+            ;
+        });
+
+        $project = Project::where('name', $name)->firstOrFail();
+        $this->projects[] = $project;
+
+        self::assertSame($description, $project->description);
+    }
+
+    public function testCreateProjectSetAuthenticatedSubmissions(): void
+    {
+        $this->users['admin'] = $this->makeAdminUser();
+
+        $name = Str::uuid()->toString();
+
+        $this->browse(function (Browser $browser) use ($name): void {
+            $browser->loginAs($this->users['admin'])
+                ->visit('/projects/new')
+                ->waitFor('@create-project-page')
+                ->type('@project-name-input', $name)
+                ->click('@project-authenticated-submissions-input')
+                ->click('@create-project-button')
+                ->waitForReload()
+            ;
+        });
+
+        $project = Project::where('name', $name)->firstOrFail();
+        $this->projects[] = $project;
+
+        self::assertTrue($project->authenticatesubmissions);
+    }
+
+    /**
+     * @return array<array<mixed>>
+     */
+    public static function visibilities(): array
+    {
+        return [
+            ['public', Project::ACCESS_PUBLIC],
+            ['protected', Project::ACCESS_PROTECTED],
+            ['private', Project::ACCESS_PRIVATE],
+        ];
+    }
+
+    #[DataProvider('visibilities')]
+    public function testCreateProjectSetVisibility(string $fieldname, int $role): void
+    {
+        $this->users['admin'] = $this->makeAdminUser();
+
+        $name = Str::uuid()->toString();
+
+        $this->browse(function (Browser $browser) use ($fieldname, $name): void {
+            $browser->loginAs($this->users['admin'])
+                ->visit('/projects/new')
+                ->waitFor('@create-project-page')
+                ->type('@project-name-input', $name)
+                ->click('@project-visibility-' . $fieldname)
+                ->click('@create-project-button')
+                ->waitForReload()
+            ;
+        });
+
+        $project = Project::where('name', $name)->firstOrFail();
+        $this->projects[] = $project;
+
+        self::assertSame($role, $project->public);
+    }
+}