-
Notifications
You must be signed in to change notification settings - Fork 0
Description
Dear Joseph,
thanks to you and Jens for the new test release of the AGENT BrAPI implementation and Jens for deploing it!
I tested the endpoints that are listed uman raedble at the landing page
https://agent.ipk-gatersleben.de/genotyping/brapi/v2/ (which is not mandatory, but good!)
and those taht are listed in the BrAPI own endpoint to list the implemented endpoints: https://agent.ipk-gatersleben.de/genotyping/brapi/v2/serverinfo
/serverinfo: OK
/samples - retrieve a list of all of the samples, e.g. /genotyping/brapi/v2/samples: OK
/samples/reference_id - retrieve a sample searched by referenceID(ex biosample id: SAMEA*), e.g. /genotyping/brapi/v2/samples/SAMEA111493800: no result found. Furthermore the replace please the human readble error message by an valide JSON response where you could include a error message error message
/callsets - retrieve a list of all callsets, e.g. /genotyping/brapi/v2/callsets: OK
/callsets/reference_id - retrieve a callset searched by referenceID, e.g. /genotyping/brapi/v2/callsets/SAMEA114474862: OK - but also here deliver a alide JSON as result whe no data can be found for a given referenceID or other parameter
/attributes - retrieve a list of all attributes, e.g. /genotyping/brapi/v2/attributes: OK
/attributes/reference_id - retrieve a attribute searched by referenceID(ex ATTRIBUTEDBID:), e.g. /genotyping/brapi/v2/callsets/10352 call set not found - but also here deliver a alide JSON as result whe no data can be found for a given referenceID or other parameter
/attributevalues - retrieve a list of all attributevalues, e.g. /genotyping/brapi/v2/attributevalues : OK
/germplasm: OK
/studies: OK
/observationunits: OK - only issue here is the attribute uploadedBy" - here we should see the person who uploaded it from genebank side to have the direct contactpoint for questions about the content
/observations: OK - only issue here is the attribute uploadedBy" - here we should see the person who uploaded it from genebank side to have the direct contactpoint for questions about the content
A last question: Did you tested Query performance when iterating over the reults using BrAPI pagination?
Thanks for your work!
Matthias